cloudquery / cq-source-simple-analytics

A CloudQuery source plugin for Simple Analytics that loads Simple Analytics data into PostgreSQL, BigQuery, Athena, and many other destinations

This plugin is now being maintained by Simple Analytics, please see the new repo here: simpleanalytics/cq-source-simpleanalytics

cq-source-simple-analytics's Issues

v1 suggestions

Great work on the plugin @hermanschaaf 🚀

I don't have much to comment, only:

1. For the first version maybe we can simplify and only have period (instead of multiple way to define a time span)
2. For the first version maybe no support incremental syncs until the plugin gets traction
3. I borrowed some of your testing code, but took a bit of a different approach with the data:
   https://github.com/cloudquery/cq-source-plaid/blob/97f78bdd8600e137379ec727250957250339c10a/resources/wallets_test.go#L22
   https://github.com/cloudquery/cq-source-plaid/blob/97f78bdd8600e137379ec727250957250339c10a/resources/testing.go#L15
   that way we don't need to update the test data if the responses change (e.g. on SDK update).

All the suggestions are pretty minor in my opinion