cloudkite-io / gcr-cleaner Goto Github PK

We need to add ECR support. The application needs some refactoring to add support to more Container Registries. I see this being implemented in several ways.
Some of them can be:

1. Run the app with a flag to specify the registry. This way we can keep the app as it is in terms of registry cleaner packages. That is, we'll need to add an ecr-cleaner package. A list of steps to implement can be:

• Add <registry_name>-cleaner packages.
• Load in main for what registry we are going to be running the app. This comes from a flag we pass in when running the binary.
• Have a package to create a cleaner package responsible to deliver a cleaner instance based on the registry.
• Create an instance of Config before getting the
• Get the cleaner configuration initialized for its respective cloud.
• Continue the cleaning process as it is.

2. Implement Domain Driven Design:

• Create a root package that define at the app level the cleaner and config domain and their respective interfaces.
• Implement packages for every registry we are going to support. We can have a gcr and an ecr package that implements the specification of types and interfaces from the root package.

Also, What do you about using a yaml file to configure the app. The change would be simple. I am jut just curious as this does not seem to add much value just that I think is easy just to edit the file than set up env vars.

MIT license is ideal.