close2 / iban Goto Github PK

in iban.dart
var iban = electronicFormat(_iban);

is iban != _iban , electronicFormat() remove some invalid chars. Example : _iban = "DE021203000000002ü02051", after electronicFormat() is iban = "DE02120300000000202051" and is valide! The function isValid return now true but the iban is not valide.

https://www.citadele.lt/en/online-banking/examples/
HU4211773016111110180000000 returns false

When calling isValid('_a') the function call results in a RangeError: Value not in range: 2`.

This happens because the iban length in isValid is checked before removing special characters and therefore specifications[iban.substring(0, 2)] will run into a RangeError

Hi @close2,

just read you're 'help wanted' commit when i was about to open a pull request for the Dart 2.12 migration.
Changes look good to me - i made the same changes, ran dart test and analyze and all seems fine. Thanks for updating.

It would be nice to get the country code, the bank account number and the routing information. Thanks

Hi

In the iban package is an error with the swiss iban specification.
The package wants the swiss iban to have a number at the last digit of the iban. Valid can also be a character.
see on this page:
https://www.ubs.com/ch/en/help/account/iban.html
Open segment: Where do I find the IBAN for my UBS account?

Could you update the specs to support ubs accounts as well?

Best regards