clearbluejar / ghidrecomp Goto Github PK

The get_calling function sets the default parameter for cgraph as CallGraph(). Using an object as a default argument in a Python function results in the object being initialized only once. This can lead to unexpected results when the function is called multiple times.

A better approach would be to set the default value of cgraph to None and then initialize it within the function if it is not provided.

def get_calling(f: "ghidra.program.model.listing.Function", cgraph: CallGraph = None, depth: int = 0, visited: tuple = None, verbose=False, include_ns=True, start_time=None, max_run_time=None, max_depth=MAX_DEPTH):
    if cgraph is None:
        cgraph = CallGraph()

https://github.com/NationalSecurityAgency/ghidra/blob/303c69ba16a28e594b0ffb6c8c45d41cf3579573/Ghidra/Features/Base/src/main/java/ghidra/program/util/GhidraProgramUtilities.java#L23

AttributeError: type object 'ghidra.program.util.GhidraProgramUtilities' has no attribute 'setAnalyzedFlag' in https://github.com/clearbluejar/ghidrecomp/actions/runs/5007536581/jobs/8974271234

Current images is built on x84-64 and runs poorly with Mac M1 Arm. (Ghidra hangs)

Build new image with --bullseye variant.

For uploading artifacts in Github workflows. need to handle trouble characters.

Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n
          
The following characters are not allowed in files that are uploaded due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

https://ghidra.re/ghidra_docs/api/ghidra/program/model/data/DataTypeManager.html#getSourceArchives()

Ensure ghidrecomp can run on Ghidra 11

Traceback (most recent call last): File "PdbPlugin.java", line 209, in pdb.PdbPlugin.findPdb java.net.java.net.SocketException: java.net.SocketException: Invalid argument: connect The above exception was the direct cause of the following exception: Traceback (most recent call last): File "PdbPlugin.java", line 209, in pdb.PdbPlugin.findPdb java.io.java.io.IOException: java.io.IOException: Unable to establish loopback connection The above exception was the direct cause of the following exception: Traceback (most recent call last): File "PdbPlugin.java", line 209, in pdb.PdbPlugin.findPdb Exception: Java Exception The above exception was the direct cause of the following exception: Traceback (most recent call last): File "", line 198, in _run_module_as_main File "", line 88, in _run_code File "C:\Users.______166\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\Scripts\ghidrecomp.exe_main.py", line 7, in File "C:\Users.______166\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\ghidrecomp_main.py", line 11, in main decompile(args) File "C:\Users._______166\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\ghidrecomp\decompile.py", line 192, in decompile pdb = get_pdb(program) ^^^^^^^^^^^^^^^^ File "C:\Users._______166\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\ghidrecomp\utility.py", line 126, in get_pdb pdb = PdbPlugin.findPdb(prog, find_opts, ConsoleTaskMonitor()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ java.io.java.io.UncheckedIOException: java.io.UncheckedIOException: java.io.IOException: Unable to establish loopback connection

Instead of using python threading, would it be faster to use ParallelDecompiler?

        from decompiler import MyDecompileConfigurer
        from ghidra.app.decompiler.parallel import ParallelDecompiler
        from ghidra.app.decompiler.parallel import DecompilerCallback
        from ghidra.app.decompiler.parallel import DecompileConfigurer

        configurer = MyDecompileConfigurer()
        callback = DecompilerCallback(program, DecompileConfigurer)

        ParallelDecompiler.decompileFunctions(callback, program, all_funcs, None, monitor)

@JImplements(DecompileConfigurer, deferred=False)
class MyDecompileConfigurer:

    @JOverride
    def configure(self, decompiler: 'ghidra.app.decompiler.DecompInterface'):
        decompiler.toggleCCode(False)
        decompiler.toggleSyntaxTree(True)
        decompiler.setSimplificationStyle("decompile")
        opts = DecompileOptions()
        opts.grabFromProgram(p)
        decompiler.setOptions(opts)

• Put decomps in own folder
• Put all output under "ghidrecomps" dir
• Update tests to ensure no folders are created in cwd

 $ tree -L 1 ghidrecomps/ 
ghidrecomps/
├── afd.sys.10.0.22621.1415
├── bsim-xmls
├── ghidra_projects
├── ls
├── ls_aarch64
└── symbols

Put all bin outout under bins

If binary names match project files will be overwritten.

ghidrecomp bin1
cd /other_path
ghidrecomp bin1

conflict!

Add ability to apply custom Ghidra GDT prior to decomp.

ghidrecomp : The term 'ghidrecomp' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. At line:1 char:1 + ghidrecomp tm.exe + ~~~~~~~~~~ + CategoryInfo : ObjectNotFound: (ghidrecomp:String) [], CommandNotFoundException + FullyQualifiedErrorId : CommandNotFoundException