clearbit / clearbit-slack Goto Github PK

Some of the recent changes, such as specifying the slack channel in the Clearbit::Slack.ping call (54eda64) are super helpful, but are not in the latest published gem - would love to see these live.

Hello! Thanks for making and maintaining clearbit-slack. I've been updating gemfiles recently in our software stack to keep them current and this has become a blocker on updating other gems.

The slack-notifier version required by clearbit-slack is capped at 1.5.1. This version of slack-notifier is 5 years old. When trying to update to a more current version of the notifier, I get

Bundler could not find compatible versions for gem "slack-notifier":
  In Gemfile:
    slack-notifier (~> 2.3)

    clearbit-slack was resolved to 0.2.2, which depends on
      slack-notifier (>= 1.5.1, ~> 1.5.1)

The latest version of slack-notiifer is ~3 years old (2.3.2) (changelog). It looks like the only breaking change is the way defaults are set using a block during initialization.

It would be good if clearbit-slack supported this version. Thanks!

Create "attachment" payloads for Person and Company. these will be used when notifying slack channel

Use our https://github.com/clearbit/clearbit-leadscore Gem for selecting which slack channel to notify

Hey Alex - could you loosen up the slack-notifier dependency in this gem?

spec.add_dependency 'slack-notifier', '~> 1.2.1'

We're using v1.5.1 of slack-notifier which is incompatible with clearbit-slack:

Bundler could not find compatible versions for gem "slack-notifier":
  In snapshot (Gemfile.lock):
    slack-notifier (= 1.5.1)

  In Gemfile:
    slack-notifier

    clearbit-slack was resolved to 0.1.0, which depends on
      slack-notifier (~> 1.2.1)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

We would really benefit from knowing what the company's tech stack is.

I broke the notifier in 0.1.8 because I didn't test it properly before merging. By adding a helper rake task we can test the end-to-end integration

Often times the Lead will also be pushed to a CRM or Admin area. We can have the Slack notification also add a link to the CRM page.