classandrew / anode

Wynncraft War Tracking Mod for Fabric 1.19.3

Anode 1.19.3

This was originally cloned from the Fabric Example Mod

---

Fabric Example Mod

Setup

For setup instructions please see the fabric wiki page that relates to the IDE that you are using.

License

This template is available under the CC0 license. Feel free to learn from it and incorporate it in your own projects.

anode's Issues

Update to 1.19.4

You should update NOW ⚡

Crash in conjunction with Wynntils

Hi, I am a developer of Wynntils. We are seeing multiple crashes that involve your mod. I believe it might be due to a bad interaction between our respective mods (or possibly that one of your assumptions about Wynncraft do not hold.)

The crash stack trace looks like this:

java.util.NoSuchElementException
	at java.base/java.util.concurrent.ConcurrentHashMap$KeyIterator.next(ConcurrentHashMap.java:3460)
	at xyz.andw.anode.listener.WarChatListener.lambda$init$3(WarChatListener.java:49)
	at xyz.andw.anode.event.ChatCallback.lambda$static$0(ChatCallback.java:12)
	at net.minecraft.class_338.handler$zzb000$anode$addMessage(class_338.java:560)
	at net.minecraft.class_338.method_1812(class_338.java)

In WarChatListener, you have the following piece of code that is causing trouble:

UUID bossbarID = uuidIter.next(); // there should always be two
                String barString = Untext.unText(bars.get(bossbarID).getName().getString());
                
                if (!barString.contains("❤")) { // it's the guild level thing, so the next bar should have a heart in it
                    bossbarID = uuidIter.next(); 

This assumption that the boss bars always come in pairs do not hold. We do boss bar manipulations in Wynntils; I can't say in the particular cases that the crash has occurred if there were more bars that has been removed/blocked by us, or if it is Wynncraft that did not create two bars (and thus your assumption is invalid).

In any case, you can make your mod more robust by checking if there really is an additional bar before trying to get it from the iterator.