Comments (4)
yikes. very sorry about the outage.
I can see two things that I really can improve here.
- That assert slipped through the cracks during my PR review. Also, we unfortunately didn't have any test cases that depended on anything that wasn't a function (for dunder methods) :/
- I could've bumped at least the
minor
component on the version since the change wasn't exactly trivial.
On the solution side, I think you're right. I think we only need it to be a callable. I'm just running the change on the CI to confirm that the change doesn't make any other version unhappy.
I wasn't sure about keeping the assert
at all but I think it'd take a little more investigation to say safely that we won't segfault the entire interpreter (which would be way harder to debug) if we receive something weirder there.
On the release side, I might release 0.2.0 as soon as we fix this issue, so we might save other people the trouble.
My little branch was really just a tiny test. A proper PR would be more than welcome.
Once again, sorry about the mess and thanks for reporting the failure.
from forbiddenfruit.
Hi @Julian. The CI is happy with the change you suggested:
https://travis-ci.org/clarete/forbiddenfruit/builds/592058249
Let me know if you'll have time to put a PR together or I'll plan to do so at some point.
from forbiddenfruit.
yikes. very sorry about the outage.
Thank you, your sympathy is much appreciated. I have assured my bitcoin
investors that the outage was a simple result of market correction (that or
Jimmy unplugged the power cable). I think they bought it.
I sent a PR (#35) which yeah is the same fix as your commit, and seems to pass.
Test included there too. Comments welcome of course.
from forbiddenfruit.
Thanks a lot for the PR! Just merged it and I'll look into releasing it this week <o/
Once again thanks for reporting the bug and sorry it caused you a headache :/
from forbiddenfruit.
Related Issues (20)
- test fails with py3.8 and pytest HOT 3
- str.__mod__ method is not patchable! HOT 1
- Unable to perfectly re-curse to __add__ HOT 2
- Cursing int with __iter__ fails with an error HOT 1
- Possible simplification of patchable_builtin() HOT 2
- Provide wheel packages? HOT 8
- Exceptions raised in cursed-in dunder methods are not raised to calling code
- Crash on Windows if dunder methods cursed into `ctypes.c_int` raises an exception
- Fix simple typo: infomation -> information HOT 1
- Replacing __hash__ returns a key error HOT 1
- Cursing dunder methods fails with: KeyError: '<method_to_curse>' HOT 5
- Patch for str __add__ not working
- object has no attribute '__dict__' HOT 1
- how to use reverse with existing attributes HOT 2
- MacOS errors monkeypatching `object`
- Undiagnosed crash (Windows 11, Python 3.10)
- How to make the additional function can be autocompleted in VS Code? HOT 1
- Add `pyproject.toml` or implement wheel-based distribution
- Unable to curse __call__
- __init_subclass__ seems to not be implemented as a cursable magic method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forbiddenfruit.