Coder Social home page Coder Social logo

Comments (4)

clarete avatar clarete commented on June 14, 2024

yikes. very sorry about the outage.

I can see two things that I really can improve here.

  1. That assert slipped through the cracks during my PR review. Also, we unfortunately didn't have any test cases that depended on anything that wasn't a function (for dunder methods) :/
  2. I could've bumped at least the minor component on the version since the change wasn't exactly trivial.

On the solution side, I think you're right. I think we only need it to be a callable. I'm just running the change on the CI to confirm that the change doesn't make any other version unhappy.

I wasn't sure about keeping the assert at all but I think it'd take a little more investigation to say safely that we won't segfault the entire interpreter (which would be way harder to debug) if we receive something weirder there.

On the release side, I might release 0.2.0 as soon as we fix this issue, so we might save other people the trouble.

My little branch was really just a tiny test. A proper PR would be more than welcome.

Once again, sorry about the mess and thanks for reporting the failure.

from forbiddenfruit.

clarete avatar clarete commented on June 14, 2024

Hi @Julian. The CI is happy with the change you suggested:
https://travis-ci.org/clarete/forbiddenfruit/builds/592058249

Let me know if you'll have time to put a PR together or I'll plan to do so at some point.

from forbiddenfruit.

Julian avatar Julian commented on June 14, 2024

yikes. very sorry about the outage.

Thank you, your sympathy is much appreciated. I have assured my bitcoin
investors that the outage was a simple result of market correction (that or
Jimmy unplugged the power cable). I think they bought it.

I sent a PR (#35) which yeah is the same fix as your commit, and seems to pass.
Test included there too. Comments welcome of course.

from forbiddenfruit.

clarete avatar clarete commented on June 14, 2024

Thanks a lot for the PR! Just merged it and I'll look into releasing it this week <o/

Once again thanks for reporting the bug and sorry it caused you a headache :/

from forbiddenfruit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.