Comments (3)
Hi @paolostivanin! Thanks for working on the porting! pytest will be the way to go for sure!
On this specific test, I am not really sure why locals()
& dir()
are diverging, but it looks like it's something pytest itself is doing (we're not the only ones to fiddle with the inner workings of dir, I guess :D).
I'm not really really sure if that test is really useful the way it is either way. I'd just change it so we don't look at things that aren't exactly relevant for the library. In other words, maybe instead of
assert dir() == sorted(locals().keys())
we could go just for repeating what we did in the previous line
assert 'a' in dir()
What do you think?
from forbiddenfruit.
Yep, makes sense :)
I'll prepare a PR by the end of the day with all the fixes 👍
from forbiddenfruit.
That's awesome! Thank you so much <o/
I'll take a look at the PR for sure!
from forbiddenfruit.
Related Issues (20)
- str.__mod__ method is not patchable! HOT 1
- Unable to perfectly re-curse to __add__ HOT 2
- Cursing int with __iter__ fails with an error HOT 1
- Possible simplification of patchable_builtin() HOT 2
- Provide wheel packages? HOT 8
- Exceptions raised in cursed-in dunder methods are not raised to calling code
- Crash on Windows if dunder methods cursed into `ctypes.c_int` raises an exception
- Fix simple typo: infomation -> information HOT 1
- Replacing __hash__ returns a key error HOT 1
- Cursing dunder methods fails with: KeyError: '<method_to_curse>' HOT 5
- Patch for str __add__ not working
- object has no attribute '__dict__' HOT 1
- how to use reverse with existing attributes HOT 2
- MacOS errors monkeypatching `object`
- Undiagnosed crash (Windows 11, Python 3.10)
- How to make the additional function can be autocompleted in VS Code? HOT 1
- Add `pyproject.toml` or implement wheel-based distribution
- Unable to curse __call__
- __init_subclass__ seems to not be implemented as a cursable magic method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forbiddenfruit.