The lastfm-sharp from clancey

lastfm-sharp's People

Contributors

Stargazers

Watchers

lastfm-sharp's Issues

Don't report a duration of zero

From 60499168cdbbe65d0221cd4cc64d14c81331d73d Mon Sep 17 00:00:00 2001
From: Alan McGovern <[email protected]>
Date: Mon, 6 Feb 2017 02:12:16 +0000
Subject: [PATCH] [Scrobbling] Ignore the duration when it's zero

If the duration has not been supplied, don't bother
reporting a zero duration. This is an optional parameter
anyway so there's no point in reporting obviously
false information.
---
 lastfm-sharp/Scrobbling/Connection.cs | 3 ++-
 lastfm-sharp/Scrobbling/Entry.cs      | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lastfm-sharp/Scrobbling/Connection.cs b/lastfm-sharp/Scrobbling/Connection.cs
index 3cc95bd..b3964ac 100644
--- a/lastfm-sharp/Scrobbling/Connection.cs
+++ b/lastfm-sharp/Scrobbling/Connection.cs
@@ -55,7 +55,8 @@ namespace Lastfm.Scrobbling
 			p["api_key"] = session.APIKey;
 			p["album"] = track.Album;
 			p["artist"] = track.Artist;
-			p["duration"] = ((int)track.Duration.TotalSeconds).ToString();
+			if ((int) track.Duration.TotalSeconds != 0)
+				p["duration"] = ((int)track.Duration.TotalSeconds).ToString();
 			p["method"] = "track.updateNowPlaying";
 			p["sk"] = session.SessionKey;
 			p["track"] = track.Title;
diff --git a/lastfm-sharp/Scrobbling/Entry.cs b/lastfm-sharp/Scrobbling/Entry.cs
index cd8ac43..9e31306 100644
--- a/lastfm-sharp/Scrobbling/Entry.cs
+++ b/lastfm-sharp/Scrobbling/Entry.cs
@@ -110,7 +110,8 @@ namespace Lastfm.Scrobbling
 			p["api_key"] = session.APIKey;
 			p["album"] = Album;
 			p["artist"] = Artist;
-			p["duration"] = ((int)Duration.TotalSeconds).ToString();
+			if ((int) Duration.TotalSeconds != 0)
+				p["duration"] = ((int)Duration.TotalSeconds).ToString();
 			p["method"] = "track.scrobble";
 			p["sk"] = session.SessionKey;
 			p["timestamp"]  = Utilities.DateTimeToUTCTimestamp(TimeStarted).ToString();
-- 
2.7.1

Recommend Projects