clamarque / angular-movies Goto Github PK
View Code? Open in Web Editor NEW:rocket: A progressive web apps of movies built with @angular 7 and the API TMDB
Home Page: https://hubmovies.fr
:rocket: A progressive web apps of movies built with @angular 7 and the API TMDB
Home Page: https://hubmovies.fr
Hello clamarque,
Can you please post the new app version on the github repo really want to play with it.
Thank you.
I wanna do something
hello clamarque ,
im french Angular trainor , i was looking at ur code cuz im teaching angular with lightly application similar than ur .
My point is simple , ur database firebase rules allow anyone with is connected to ur app to modifiy ur database by adding / modifying / deleting any documents or collection anywhere in ur firestore database . U should upgrade ur firestore rules with more restrictions :)
by the way few update notice to improve ur app :)
adding StrategyPreloading : PreloadAllModules ( app-routing.module.ts in Router.forRoot() config )
100% SEO is not revelant as there is no Angular Server side rendering part in your app
PWA will be very improve is ur were using DataGroup settings in ngws-config in order to cache api part for offline navigation ( one of most imp criteria of been PWA ready )
u should considering using environment files for managing endpoint api url
and api key
HttpParams will help ur service to reduce ugly http params string concatenation ( even if ur using template string which is still better than '+' ^^ )
u should considering creating a custom pipe for managing by default image in case of missing poster
u should really change ur search bar in order to use ReactiveForms in order to have better user experience ( valueChange of FormControl provide Observable of change of ur input search )
Good Job by the way .
Hoep u will appreciate my remarks .
Regards,
Pierre
How did you solve the cors problem?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.