clamarque / angular-movies Goto Github PK

Hello clamarque,
Can you please post the new app version on the github repo really want to play with it.
Thank you.

I wanna do something

• update angular
• add playlist
• add TV show
• add Popular, top rate movie/tv
• ...

hello clamarque ,

im french Angular trainor , i was looking at ur code cuz im teaching angular with lightly application similar than ur .

My point is simple , ur database firebase rules allow anyone with is connected to ur app to modifiy ur database by adding / modifying / deleting any documents or collection anywhere in ur firestore database . U should upgrade ur firestore rules with more restrictions :)

by the way few update notice to improve ur app :)

• adding StrategyPreloading : PreloadAllModules ( app-routing.module.ts in Router.forRoot() config )

• 100% SEO is not revelant as there is no Angular Server side rendering part in your app

• PWA will be very improve is ur were using DataGroup settings in ngws-config in order to cache api part for offline navigation ( one of most imp criteria of been PWA ready )

• u should considering using environment files for managing endpoint api url
  and api key

• HttpParams will help ur service to reduce ugly http params string concatenation ( even if ur using template string which is still better than '+' ^^ )

• u should considering creating a custom pipe for managing by default image in case of missing poster

• u should really change ur search bar in order to use ReactiveForms in order to have better user experience ( valueChange of FormControl provide Observable of change of ur input search )

Good Job by the way .

Hoep u will appreciate my remarks .

Regards,

Pierre

How did you solve the cors problem?