clagraff / devoid Goto Github PK

We should have a test harness or something for running acceptance tests which send key events to the client, to cause intents sent to server, to result in mutations, etc etc. Maybe contained as a separate package?

Now
When a client connects, they will be subscribed to their entity ID and current position; a perceive intent is also immediately created to be processed.

The architectural idea seems to be that a Perceive intent will be created and consumed each time something affects an entity; yet, this does not impact the subscribers.

The Problem
Since the Perceive (or any intent) doesn't modify subscribers, it means performing any action has no impact on subscribers, neither adding nor removing.

As an example:

An entity moves to a new location. They immediately perceive their surroundings. But since they have not been subscribed to any of the new Positions they can now perceive, should a monster/player/etc move into their viewpoint, they would not know until they Perceive again.

Future
Create a new subscription/mutator system.

Executing an intent should return server mutators, and then a list of (mutators, identifiers) pairs, where we have a list of mutators and a list of identifiers, possibly multiple times.

Maintain a map of identifiers to connected clients (from when tunnels are created or closed). Using that map and the identifiers, ensure that a given mutator is not sent multiple times for a given client.

As an example, a Move mutator may want to be sent by both the Source ID as well as the new position, but that shouldnt generate two mutations of the same data to the same single client.

The current client code could certainly contain copious changes culminating collectively in a better developer experience.

Specifically, segregating rendering code, mutation & state mgmt, and GUI event handling into separate structures. Right now it is all combined and makes for a messy, and convoluted codebase.

Intents should be handled concurrently, withouth locking entities (maybe they get a copy of the structs they need?).

When mutations from intents are created, they should only change 1 entity per mutation.
Then mutations should operate on the pointers of entity structs, concurrently, locking the one struct they need.

This is essentially to revert: https://github.com/clagraff/devoid/pull/4/files#diff-91bbeda7eb98a7adc57b9e47e2cf5c2bR171

Add support for an entity which can block player movement when "closed", but becomes passable when "open". Yet, not all are able to have their passability toggled.

cmd/client/main.go
40:     info := network.MakeConnInfo("localhost", 8080, cfg.ClientID, "/home/clagraff/selfsigned.crt", "")

In the [client main][cmd/client/main.go] file, the certificate path is hardcoded. This should be changed to pull from the configuration file.

The current TUI library used by our ASCII client is termbox, but support for this library has halted. It is suggested to use tcell instead.

Make the switch now, while client-code is minimal.

^^ see title

The readme should include information about how to download dependencies, build, and run the application.