ckolbptb / inhomcorr Goto Github PK
View Code? Open in Web Editor NEWLicense: Apache License 2.0
License: Apache License 2.0
This line should fail if the qmri shape checks work as expected.
The qmrdata object should get a shape fixed at the first assignment of .t1 . the second assignment with a different shape should then fail.
we should fix both.
We discussed and decided to move the base classes/interfaces/... from the "interface" subfolder to the individual submodules and adjust the naming accroding to what they actually are.
MRData
QMRData
ImageData
should be moved to the inhomcorr folder (not into a specific submodule)
Currently only ImageData is covered with tests not QMRIData.
If I undestand it correctly than currently we don't specify anywhere if we want a tensor on the CPU or GPU.
Would it make sense that the MRData class has a function .cuda()
and .cpu()
? This would then e.g. move _data
and _mask
to GPU/CPU for ImageData and _t1
_rho
and _mask
for QMRIData.
How do you normally specify the device? Is this a global variable you set and then everything is put to the same device or do you specify this for each tensor?
I believe it would be usefuull to just be able to set the image in the constructor. There are lots of places were we otherwise have the sequence of
img=ImageData()
img.data=image
I would even go so far to have the image mandatory in the init. Soi we never have an imageData that does not have an image tensor.
InhomCorr/tests/test_data_loader.py
Line 16 in 70983e5
The path of where the tests are installed might not be writable when executing the tests.
Hey everbody,
close to the end, CK and I had the discussion about some of the None's
I believe we came to the following conclusions:
Otherwise we have to check for None everywhere and write lots tests that handle these corner cases in each downstream function...
What do you think?
This will be a reminder for missing tests.
So far we have not specified the unites of e.g. t1 anywhere. We could
I would prefer option 2. What do you think?
Like Python has built-in support for properties, it also has built-in functionality for indexable objects via getitem .
An example would be the get_data
function in for the dataloaders. We could try to design it in a way that the QMRIDataLoader is indexable (Pseudo-Code):
class QMRIDataLoader:
def __getitem__(self, id):
return self.item[0]
Then, later one, we could use it as
obj=QMRIDataLoader(...)
obj[0]
This would make it more 'pythonic' and consistent, for example, with how pytorch datasets are supposed to work.
Is the most likelz culprit. This should be a pip install -e .
We have default docstrings in some places,
for example
InhomCorr/src/inhomcorr/mrsig/flash.py
Line 13 in 90c0b7a
should contain a description and the units etc in the docstrings, instead of
_description_
Somebody should go through main and see where we messed up so far and fix it, and we should maybe remember to check in in code review (Mea culpa, I missed it).
On the other work-in-progress branches we might have also those, I will try to remember to complain about those during the review of the PRs..
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.