ckim42 / core-data-structures Goto Github PK

Good job on completing the second coding challenge. Here's some feedback:

• Your set stores tuples: key, value pairs. This is usually not the way sets work. Sets usually store washable values —> single elements. Key, value pairs are conventionally for dictionaries.
• Union and length method is failing your tests currently.

• First of, I would like to say, amazing job on your medium article. I loved reading it!! What an interesting way to connect binary trees to something affecting a lot of us HUGELY right now. It was very engaging! :)
• Challenge yourself by implementing a tree map or the delete method for a binary search tree!

Topics discussed: readability, organization, effectiveness, testing, complexity

Readability and Formatting

• Variable names are semantic and easy to follow when reading the code -- I really like the use of bucket_quantity instead of new_size in your resize() method!
• Lines are short, casing and formatting is consistent
• The comments made me actually laugh out loud several times (a good example would be your set() method)

#the _ is the equivalent of 'private' - says this is an internal method only to be called within the class, so don't call it outside.
#not to be confused with __, i.e. mangle, which makes it even more private lol
#alan says 'seriously guys don't touch this' (this='mangle')

• Comments explain what's happening in the code, and other comments that explain alternate concepts (Python things, thought process of how you figured something out, etc). Really useful for future use and studying! 👏👏👏

Organization and Modularity

• Code is loosely coupled and broken into functions appropriately
• Love that you keep code that maybe wasn't as good when you learn new ways to do things, and leave notes for yourself explaining that growth! (lines 174-186)

Effectiveness of Solution

• Code creates a hashtable and can solve using different input.

Testing and Error Handling

• Lots of tests! With good commenting so you can see where edge cases are tested etc.

Algorithmic Complexity

• Might be worth it to annotate time complexity in the TODOs (i'm a hypocrite haha), because it looks like the code is in its best case!

Standard Library/Conventions

• Side note: making a new convention for myself based off your code and it's called "wow emojis in code comments??? why don't I do that?" 🤷

Good job on completing your first submission. Here's what you can do to improve:

• Palindrome Recursive function: FIX TYPO! You are passing in parameter “text” and trying to use undefined parameter “split-text.”
• I see that you attempted to refactor your code. However, there is still duplicate code in your file. The find_index and find_all_indexes seems to have a lot of duplicate code! Try to see if you can use helper functions or use one of the functions in the other one, such that there is no duplicate code in your file!
• Its best to always run and test your code before submitting. For your linkedlist_test file, you have a unittest function with no content in it. Either tell it to pass or remove it because it cannot compile otherwise.