ckeditor / ckeditor4-presets Goto Github PK

For example plugins/language/lang/en.js has the header while plugins/mathjax/lang/en.js doesn't.

It seems one line files don't get minified (so they are just copied from source) while longer files gets minified which removes the copy header (haven't verified this hypothesis though).

Follow-up of #53. Demo presets is only available on demo branch.

Extracted from #56 (review).

tl;dr:

If you build demo preset (only available on the demo branch), which is used on our webpage, and try to open sample, you get an error:

Preset build flow is a bit different for the websites, but still ./build.sh demo should produce working editor.

Details:

#56 (comment)
#56 (comment)
#56 (comment)

Due to removing flash plugin from ckeditor4 repo, we should also remove it from presets.

Since we did a first step and added exportpdf plugin as npm dependency maybe it will be good to use this approach for all external plugins we have here (and will have in the future)?

Now we are in the situation were some plugins are npm deps and some git submodules. Generally, it makes sense since exportpdf plugin is fetched from npm, while SCAYT and WSC are fetched from git repos.

However, it means we have two mechanisms for fetching external plugins. And since npm is now a step of the build proces itself it will mean better integration and prevent from forgetting about updating plugins submodules. IMHO npm deps are easier to diff and see which version is used - since submodules just point to commit hash so one have to click the link and see which particular tag/version it is, while git npm dep can link to specific branch, tag or commit which is clearly visible. WDYT?

Here's the plugin build config that I am trying to use. Its a customized version of the basic build config. When I use the build process to generate the compiled files, the plugins included in the plugin folder are different from those included when using https://ckeditor.com/builder.

Any reason why this is so? I am doing something wrong?
basic-build-config.txt

Currently only master and major branches are being tested during CI in ckeditor4 repository. However it'd be nice to test also changes proposed in PRs here.

There are two versions of license banners:

/**
 * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
 * For licensing, see LICENSE.md or http://ckeditor.com/license
 */

and

/**
 * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
 * For licensing, see http://ckeditor.com/license
 */

It seems that the first version is used only in presets/<name>-ckeditor-config.js. As we don't have LICENSE.md file in this repo, probably we should stick to the second version.

Following ckeditor/ckeditor4#4423 in the nearest major release of CKEditor 4 we should do the following:

• Remove WSC from the default setup in CKEditor 4 presets.
• The WSC plugin should be still available in the plugins folder as opt-in solution until Q3/Q4 2021 in std-all / full-all distributions.
• Update the documentation stating that the WSC plugin is no longer a part of CKEditor 4 presets, but can be added via the online builder and/or through extraPlugins in case of a CDN.

(remember about our demo preset too)

Introduced in 07df69c

There is a -v switch which should return only the CKEditor version

but because of those changes version fetched is:

Installing NPM dependencies...

Copying plugins from NPM directory...

4.16.0/

Currently build.sh removes zip and tar files after running builder, but it's possible to not created those files at all.

The plugin itself is very light and as of 4.8.0 we have all other dependencies in the editor: https://github.com/ckeditor/ckeditor-dev/blob/dee99e283ce259f8e16f1092e3d7613a5e45a499/plugins/uploadfile/plugin.js

The benefit of enabling it is that users could drag & drop much more types of files than just images into the editor.

As this was a reason for ckeditor/ckeditor4#2588.

Likely not the appropriate spot, was looking to clone and build ckeditor on my own because the website version is partially broken for custom builds. Does this version in github provide a custom build mechanism or would I just need to copy one of the presets and configure it for myself?

Similar to ckeditor/ckeditor4#1591.

See ckeditor/ckeditor4#4932

I suppose it should go into full preset only, but cc @f1ames

Placeholder text plugin issue: ckeditor/ckeditor4#3793

The result of running build.sh on OSX:

Copying extra plugins...

usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ... target_directory

64
undefined

Time to greet year 2018.

Let's update any references in license headers and docs.

bc command used here is not available on Windows, and causes the script to throw an error.

I just tried to create a new preset with a new name and encountered an error - it is impossible to run build.sh because it allows just 3 different predefined names (basic, standard, full).

The following lines could be modified:
https://github.com/ckeditor/ckeditor4-presets/blob/master/build.sh#L34-L46
Instead build.sh could check the presets folder for a given name and exit with an error if the build config and the editor config with given name do not exist.

Followup to #43

Let's check out if we could do the same with mathjax, so the whole building process is nicely optimized. See also #45

For years we've been bumping CKE version literal in build script.

Since we have CKEditor on npm for quite a while it make sense to get this information at runtime from package.json rather than complicate our life by bumping it in multiple places.

#uploadimage plugin should be enabled in standard and basic full preset as ckeditor/ckeditor4#1249 gets closed.