cjoudrey / gluahttp Goto Github PK

Default value should be true.

When set to false, HTTP redirects are not followed.

It might be useful to have a helper to set basic auth headers, would you accept PR?

Example usage:

http.request_batch({
  {"GET", "http://example.com", {query="page=1"}},
  {"POST", "http://example.com", {form="username=bob&password=secret"}},
})

Instead of returning body, status, headers on success and nil, error on failure, we will return response on success and nil, error on failure.

response table will have the following properties:

• body string
• cookies table
• headers table
• status_code number

// The http Client and Transport guarantee that Body is always
// non-nil, even on responses without a body or responses with
// a zero-length body. It is the caller's responsibility to
// close Body. The default HTTP client's Transport does not
// attempt to reuse HTTP/1.0 or HTTP/1.1 TCP connections
// ("keep-alive") unless the Body is read to completion and is
// closed.

It seems like we currently are not closing res.Body on successful request:

VM blocked on Recv even after cancelling context. So the function of doRequest may should add follow code:
ctx := L.Context() if ctx != nil { req = req.WithContext(ctx) }

Maybe this is a silly question but I'm trying to use this and I'm having trouble setting the request headers.

I used the example in the readme:

import "github.com/yuin/gopher-lua"
import "github.com/cjoudrey/gluahttp"

func main() {
    L := lua.NewState()
    defer L.Close()

    L.PreloadModule("http", NewHttpModule(&http.Client{}).Loader)

    if err := L.DoString(`

        local http = require("http")

        response, error_message = http.request("GET", "http://example.com", {
            query="page=1",
            timeout="30s",
            headers={
                Accept="*/*",
                Content-Type="application/json", // THIS DOES NOT WORK? 
            }
        })

    `); err != nil {
        panic(err)
    }
}

The headers that are passed in are of type table. But for a tables field name I can't use the - character. For http header like Content-Type this character is necessary. Is there a way to work around this.

Add a way to set max_connections and max_connections_per_host to simulate browsers behaviour.

I need response.headers['Location'], and in python I can do it by http.post(url, data, allow_redirects=false), I wonder how can I make it in gluahttp.

Signature: http.get(url [, options])

Is it possible?

$ cat sun.lua
local http = require("http")

$ glua sun.lua
sun.lua:1: module http not found:
no field package.preload['http']
CreateFile .\http.lua: The system cannot find the file specified.
CreateFile C:\opt\lua\http.lua: The system cannot find the path specified.
CreateFile C:\opt\lua\http\init.lua: The system cannot find the path specified.

https://github.com/yuin/gopher-lua#standalone-interpreter

Signature: http.post(url [, options])