The kondition from cjheppell

kondition's People

Contributors

Watchers

kondition's Issues

Deployments with ready replicas are reported as unavailable

Kondition will report a deployment as 'unavailable' even if it has some ready replicas.

The condition for deployment readiness:

kondition/internal/kubernetes/statusclient.go

Line 56 in 20b5bf7

if condition.Status == corev1.ConditionTrue {

Requires all replicas in the deployment to be ready. This is probably too strict.

The problem can be reproduced with this deployment:

apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    app: busybox
  name: busybox
spec:
  replicas: 5
  selector:
    matchLabels:
      app: busybox
  strategy: {}
  template:
    metadata:
      labels:
        app: busybox
    spec:
      containers:
      - image: busybox
        name: busybox
        command:
        - sh
        - -c
        args:
        - 'while [[ true ]]; do touch foo; sleep $(($RANDOM % 10 + 3)); rm foo; sleep $(($RANDOM % 10 + 3)); done'
        readinessProbe:
          initialDelaySeconds: 5
          periodSeconds: 1
          exec:
            command: ['cat', 'foo']

This creates a deployment whose number of ready replicas will fluctuate between 0 and 5. Kondition will report the deployment as unavailable unless all 5 replicas are ready.

One solution to this would be to allow the minimum number of ready replicas for a deployment to be specified via services.yaml.

Recommend Projects