civclassic / bastion Goto Github PK

Can copy almost everything from /cti

https://github.com/CivClassic/Citadel/blob/master/src/main/java/vg/civcraft/mc/citadel/listener/ModeListener.java

• This occurs when breaking a bastion:
  • by directly mining the block the bastion goes into negative health
  • by placing blocks the bastion is destroyed yet replacing a bastion in its place shows a bastion with negative health (some players report the bastion is not destroyed and simply goes into negatives)
• Some bastions with negative health block placements, some do not (?)
• Negative reinforced bastions return to full health on server restart

This has been an issue since the 1.16 update. I will update this issue when I get a chance to test properly.

Should use CivClassic/NameLayer#20 once its in master, labelling wontfix for now

Hostile bastions (City and Vault) don't block reinforcements.

I have not been able to reproduce this bug on my test server.

Nevermind, I was still on my local civ14 branch (71ce8fc723f54e0e437bdb4ac408c9e468abac7a) and the bug wasn't present. The bug is present on the latest version on master.

EDIT: Seems to have been broken by e554b4b457d7b2bfea182b77e2c04fbc4ebbf6f5

Post 1.14, water placed in or near a vault bastion field will be blocked from flowing more than a single block.

This does not affect city bastioned towns or pre-existing flowing water. It is hard to determine why sometimes it flows one block or will stop flow outside of nearby bastions.

Bastions cancel many types of action yet not all cancellations result in the bastion taking damage. It would be more intuitive if the cancellation message told players whether the action caused bastion damage.

Decayed bastions will only take one point of damage when placing a block

Reported issue by a player, I tested while maturing and after already matured. Reinforcement material is returned, the bastion block is removed despite being broken by a group owner with ctb on.

[09:37:31 ERROR]: [Bastion] Reinforcement no longer exists, but bastion not removed, fixed at Location{world=CraftWorld{name=world},x=950.0,y=1.0,z=-450.0,pitch=0.0,yaw=0.0}
[09:37:31 ERROR]: [Bastion] Reinforcement removed during BastionBlock instantiation, removing at Location{world=CraftWorld{name=world},x=950.0,y=1.0,z=-450.0,pitch=0.0,yaw=0.0}

Spam of messages like this will show up every restart

Placement/reinforcing should still be cancelled, but it shouldnt damage the bastions, should be string list in config.

Needed for enabling scaffolding

I was playing around on the test server and it was blocking elytra flight outside of the range of the bastion, and it caused the player to be stuck mid-air

Presently players can't determine what group their bastions are on unless they click them with CTI