cirla / gdpr_consent

GDPR Transparency and Consent Framework SDK for Rust

Hi there 👋

gdpr_consent's Issues

Error in encoding vendor consents

There seems to be an error in encoding vendor consents: when I try removing a single consent from the middle of a list, it removes the successor as well:

extern crate gdpr_consent;
use gdpr_consent::vendor_consent::VendorConsent;
use std::error::Error;

fn main() -> Result<(), Box<Error>> {
    let template = "BOEFEAyOEFEAyAHABDENAI4AAAB9vABAASA".parse()?;
    let VendorConsent::V1(mut v1) = template;
    v1.vendor_consent.clear();
    for vendor_id in &[0, 1, 3, 4] {
        v1.vendor_consent.insert(*vendor_id);
    }
    // Print out the contents; vendor_consent: {0, 1, 3, 4}
    println!("{:?}", v1);
    // Serialize
    let as_str = VendorConsent::V1(v1).to_string()?;
    println!("{}", as_str);
    // Deserialize
    let check = as_str.parse()?;
    let VendorConsent::V1(v1_2) = check;
    // Print out contents again; vendor_consent: {0, 1, 4}
    println!("{:?}", v1_2);
    Ok(())
}

Add more comprehensive testing and fix kcov/coveralls

Use tools like http://gdpr-demo.labs.quantcast.com/user-examples/cookie-workshop.html and http://acdn.origin.appnexus.net/cmp/docs/#/tools/vendor-cookie-decoder to construct more encoding/decoding examples to add more test coverage and test corner cases.

The coverage script in .travis.yml needs to be fixed as it is now only reporting coverage for src/lib.rs and not src/vendor.rs where the actual code lives.

Consider switching parsing from nom to bitstream-io

Consider switching parsing from nom to bitstream-io to reduce the number of dependencies.