Comments (10)
Ah, now I understand; thank you.
The confusion is partly because once the switch has been cycled from the default, it is not possible to tell if the action will be toggled or if it will be set to Off, and there is no way to restore the default without starting again (which is probably why the selected action is being removed).
Anyhow, thank you for your help.
from freeshow.
Could you explain further? I added one "Run action" (with multiple triggers) to a slide, that worked. And I set "Custom activation" on that, and all the actions in the single action were triggered.
from freeshow.
My reported issue was probably mainly due to my misunderstanding of enabling, triggering, run action, and toggling of custom actions, which you partly clarified in #636.
Now that I have a better understanding, I've retested using the below custom action, with a Toggle action for it placed on a slide. It functions mostly as expected. While testing, I found:
-
Toggling actions changes the Enabled status in the defined action in the drawer. So if the action was defined with Enabled deselected, it becomes defined with Enabled set to selected. If the app is closed before the action is toggled for a second time (to revert to its original state), the action is saved with the Enabled state toggled. So, the next time the show is played the sequence is inverted. As I see it, toggling an action should not alter the saved defined action.
-
Although action 4 (in my example) is effective in toggling the action, so that the action is disabled for subsequent slides, it does not alter the Enabled status of the action. This is confirmed when the action config is viewed in the drawer. When the action is toggled again, it is out of sequence.
However, when, instead of action 4, a stand-alone toggle action is applied to the following slide, the Enabled status is changed, as evidenced in the app drawer. -
After action 4 in my custom action executed, none of the timers can be restarted. In the drawer, they appear to be reset, show as playing, but do not decrement. The app has to be closed and reopened to recover. This does not happen when a stand-alone toggle action is applied to the following slide.
-
Custom actions dragged and dropped from the drawer do not function or display correctly.
-
Adding the action Stop active timers to my custom action, appears to do nothing.
from freeshow.
- Users can manually enable/disable actions so it makes sense that this will be changed. But you can set the toggle state to on/off (using the checkbox) to ensure it's set to what you need it to be (in your screenshot it will always be set to "on").
- You need to choose an action to be toggled using the dropdown (this can't be the same action that triggers it!
- This is because you have not set an action to toggle, but I will fix this "freeze" error!
- I'll fix this behaviour.
- Same reason as point 3.
from freeshow.
Thank you.
I'm still finding the UI confusing when adding a Toggle action to a custom action. In particular, the behaviour of the toggle switch and the removal of the selected action when the switch is enabled.
Please clarify the intended behaviour when:
- Adding a Toggle action without selecting an action to toggle. I've assumed the toggle applies to the action being edited, as it can be saved without defining the action.
- The switch is enabled and the selected action to toggle is removed.
from freeshow.
You should always select an action to toggle when choosing "Toggle action", but it's set to "-" by default so no action is accidentally toggled. If you don't select any action, or the selected action does no longer exist then it will do nothing! (I will fix it so it does not freeze in this case)
from freeshow.
Thank you, That helps.
However, I still don't understand the function of the switch, especially as it removes the selected action when it is enabled after selecting an action to be toggled.
The switch has an initial/default on/selected state before selecting an action to be toggled. This implies something is active, and is then deactivated once an action to be toggled is selected, which seems to not be the case.
from freeshow.
I see, this is a bug. Will fix this as well.
from freeshow.
Ah, good; thank you.
Then, is my understanding of the intended function of the switch now correct?
- When Off/deselected: selected function will be toggled (Enabled status will be inverted).
- When On/selected: selected function will be enabled, irrespective of its present state.
If so, consider amending the text "Action will toggle if checkbox is unchanged" to be dependant on the state of the switch, and keep it visible. For example:
When switch is off/unselected/default display "Action will be toggled"
When switch is on/selected: "Action will be enabled"
from freeshow.
If the checkbox is unchanged it will toggle the value (as the text explains), but if it's set to on OR off again (deselected), the action will be set to on OR off accordingly!
from freeshow.
Related Issues (20)
- Applying Styles automatically to slides HOT 1
- Paste in a text box fails HOT 3
- Merge slide text feature request HOT 3
- Capitalize doesn't always work on slide text HOT 3
- Auto-capitalization for song lyrics HOT 3
- [Bug Report] Can't open the app. "Unexpected end of JSON input" HOT 3
- [Bug Report] Projects and Show Categories Not Syncing with Google HOT 1
- [Feature Request] Add stage layout switching per display HOT 4
- [Bug Report] Enabling OutputShow freezes/lags the whole application HOT 1
- [Bug Report] Current slide text output does not update if first non-stage output is disabled HOT 3
- [Feature Request] Add Text size down/up option to text boxes
- Bug Report: FreeShow App Using 104% CPU and Slowing Down HOT 10
- Chord Pro Import HOT 1
- [Feature Request] Auto fit text to slide preview HOT 1
- [Bug Report] Interface freezes/slow response HOT 2
- Javascript Error: EPERM Operation Not Permitted (Dropbox issue?) HOT 1
- [Feature Request] Skip SECTIONS if nothing is typed in them
- [Bug Report] Certain Fonts not showing even when installed HOT 3
- [Feature Request] Remote Camera Switch HOT 1
- [Feature Request] In Triggers need to Button style.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freeshow.