Coder Social home page Coder Social logo

blog's People

Contributors

chumaknadya avatar

Watchers

 avatar

blog's Issues

Code review

  1. https://github.com/chumaknadya/Blog/blob/master/app/api/blog_api/v1/articles.rb#L33 regex is good

  2. Need to rescue an exception if not found https://github.com/chumaknadya/Blog/blob/master/app/api/blog_api/v1/articles.rb#L27

  3. It's better to use methods with ! because they raise an exceptions https://github.com/chumaknadya/Blog/blob/master/app/api/blog_api/v1/articles.rb#L37

  4. And you can rescue an exceptions in Grape way rescue_from(Grape::Exceptions::ValidationErrors) { |e| error!(e.message, 422) }

  5. Validations are pretty good https://github.com/chumaknadya/Blog/blob/master/app/models/article.rb#L1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.