Coder Social home page Coder Social logo

chuanqisun / jasmine-mock-factory Goto Github PK

View Code? Open in Web Editor NEW
8.0 3.0 5.0 164 KB

A Jasmine helper for creating mocked classes

License: MIT License

TypeScript 98.97% JavaScript 1.03%
mock jasmine moq testing jasmine-tests unit-test test-utils typescript

jasmine-mock-factory's Issues

Definition of interface SpiedMember

export interface SpiedMember {
    _func?: jasmine.Spy;
    _get?: jasmine.Spy;
    _set?: jasmine.Spy;
}

Can these properties be defined as non-nullable?

When strictNullChecks is set to true, following recommended usage produce error:

service._spy.toDataObject._func.and.returnValue({ id: null }); // Object is possible undefined

to avoid this error I must use following constructions, which looks dirty.

service._spy.toDataObject._func && service._spy.toDataObject._func.and.returnValue

Key assignment error TypeScript 2.9

TypeScript 2.9 made changes to keys so that they can be of types string | number | symbol, instead of just string. In src/lib/index.ts lines 82, 85, and 92, propertyName: keyof T is being passed into ensureProperty which takes a string, causing an error to occur when compiling with TypeScript 2.9.

Modernize test dependencies

The library currently depends on Angular Cli 1.1.0 to run all the jasmine tests. This is a unnecessary dependency that bloats the library by a lot. I'm adding this issue to collect ideas to track the work for modernizing the test dependencies. Ideally, typescript + jasmine + some light-weight test runner is all we need.

access a getter spy error

var AppService = /** @class */ (function () {
    function AppService() {
        this.appInitialized$ = new BehaviorSubject(false);
    }
    Object.defineProperty(AppService.prototype, "isAppInitialized", {
        get: function () {
            return this.appInitialized$.getValue();
        },
        enumerable: true,
        configurable: true
    });
const appService = MockFactory.create(AppService);
appService ._spy.isAppInitialized._get.and.returnValue(true);
TypeError: Cannot read property 'getValue' of undefined
           // if target is property
            if (typeof this.prototype[propertyName] !== 'function') { // <--- error here
                // we add getters and setters to all properties to make the read and write spy-able
                var descriptor = {
                    get: /* istanbul ignore next: Can't reach. spyOnProperty() requires its presence to install spies */ function () { },
                    set: /* istanbul ignore next: Can't reach. spyOnProperty() requires its presence to install spies */ function (value) { },
                    enumerable: true,
                    configurable: true,
                };

Why Object.getOwnPropertyDescriptors(this.prototype)[propName] is not used?

Adapt tool for jest

Unfortunately, this helper does not work for jest.
But there are few place to fix.

        const getterSpy = spyOnProperty(this.stub, propertyName, 'get').and.callFake(() => this.spy[propertyName]._value);
        const setterSpy = spyOnProperty(this.stub, propertyName, 'set').and.callFake(value => this.spy[propertyName]._value = value);
// =>
        const getterSpy = jest
            .spyOn(this.stub, propertyName, 'get')
            .mockImplementation(() => this.spy[propertyName]._value);
        const setterSpy = jest
            .spyOn(this.stub, propertyName, 'set')
            .mockImplementation((value) => (this.spy[propertyName]._value = value));
const spy = jasmine.createSpy(propertyName);
// =>
const spy = jest.fn().mockName(propertyName);

Maybe possible detect environment in runtime and call appropriate methods? Or it is better to create separate module for jest...

Use intersection types to allow strong typing of jasmine Spys

Hey nice project!

I was working on something similar was looking for something open source and found this. I found that you can tighten up the typing by defining an intersection type return on the create method. eg

export class MockFactory {
    /**
     * create a mock object that has the identical interface with the class you passed in
     */
    public static create<T extends object>(blueprint: Type<T> | T): Proxy<T> & {[M in keyof T]: jasmine.Spy} {

It allows you to do

mockClass1Instance = MockFactory.create(Class1);
mockClass1Instance.publicMethod.and.returnValue(999);

Without having to type cast mockClass1Instance.publicMethod as jasmine.Spy

Hope it helps!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.