chrwei / archreactoros Goto Github PK

Clicking the 'setting' button after enabling the gateway, the UI shows the green confirmation but apparently the DB isn't updated. Returning to the page still shows the gateway disabled.

Use php5 specifc OOP keywords such as public and private properties and methods, use magic functions such as __get(), __toString(), etc...

Generally improve on Object Oriented code.

If file aren't writeable or another error occurs, replace the "next step" button by a refresh button

Check the messges inside templates and source files. Improve the spelling and syntax.

Allow active, paid up, full and supporting members to view the active membership list and contact details. add a db field on products to not that a membership level is allowed to view the list.

reason for this feature that Missouri State code governing non-profits requires members to have access to the membership list. Maybe make a config pref to turn this off in case other spaces don't want it.

Either display inactive users in a different color or add a column to the user list that states the user account's state.

Alternatively or additionally, add a checkbox to the search form to select whether inactive users should be shown or hidden.

Chmod'ding to 777 is BAD.
Instruct site admins to change the file owner and if required set file permissions to 660 or 770 for directories.

manage equipment:

• serial numbers, descriptions, date received, etc
• owned or on loan and from who?
• on loan to someone?
• maintenance history

I get the fatal error below right after telling ArchOS to fresh install. This has happened every time I tired using freshly pulled files from the git repository and a fresh SQL database.

Error Code:"Fatal error: Call to a member function Execute() on a non-object in /home/tdfb/public_html/ieee/lib/functions.php on line 7"

Some organizations might want to use custom addons, i.e. to manage their library or inventory.

Whatever organizations might want to use, offer an API interface that allows to interact with AROS using http requests/RESTful services.

fix tabs/spaces. i'd like to see all tabs and no spaces. I'm not going to be picky about braces, as long as it's readable.

get rid of it. Pass vars in as function params by reference or use the $GLOBALS[] array.

Suggestion:

Remove all specific code from admin/payment.php.
Define interfaces and an abstract class that need to be implemented by new payment gateways.

used a quick hack to make single letter and 3 letter product codes for use in the interfaces and I put them in the unused path and url fields. rename these fields.

Most frontend files such as order.php or admin/payment.php have very long functions that should be broken into several functions and possibly even turned into OO code.

Variables should be renamed to more generic names and refactored to decrease the use of distinct variables dramatically and ease code handling.

Also, order.php should allow for dynamically added payment options through extensions

Some strings are inside gettext functions _() others are not.
Put them all inside those functions to allow for full i18n.

Instead of saving "admin" in the user table, create both group an user_group tables, allowing for multiple usergroups and fine grained permissions.

Also, the user class holds multiple identical or nearly identical methods.
Redo the whole class.

modularize templates further, so that there is only one search form template, only one item listing template, etc...

init.php instantiates all classes by default.

Only objects that are required everywhere and save state (i.s. Smarty, AdoDB, Dispatcher) should be instantiated by default.

Add comments to code where adequate.

Implement an autoload function that automatically includes class files according to a specific naming convention.

I.e. : class ClassName is inside lib/class_name.class.php

Simple thing: address, city, state, and zip are required but the UI doesn't indicate that.

Allow for the creation of modules and plugins based on hooks (I <3 hooks ;)) to allow specific extra actions to be performed or code to be executed depending on the installed modules.

An example of a plugin would be to change group ids in a Mediawiki database upon payment of a membership fee.

Another example of a module would be to allow users to subscribe to custom services. (i.e. an SMS notification service) or create repositories on the organization's development server, and so on)

It doesn't appear in the admin panel anymore but is still in the DB and can't be recreated with similar credentials.

Make errors traceable by throwing exceptions where adequate and add exception handling for recoverable errors.

When aros isn't installed, redirect to the installer.

After an initial install in a clean database, I created a product product_id 1 was automatically assigned. On the front end, however, the membership type field was still blank.

I created a second membership and the front end reflected only the second product (product_id =2) .

I deleted the first one, and the second continues to work.

get rid of all the "safe extract" bullshit and reference post and get vars directly. specifically copying to a local var is fine.