chrismckee / cryptsharp

GIT Clone of the source files in http://www.zer7.com/software.php?page=cryptsharp

Hello there 👋

cryptsharp's Issues

SCrypt salt issue

I found an issue with SCrypt that will cause it to generate the same hash every time with different salts.

First I generated a random string of characters from the full character set (char)0 - (char)65535.

private static string NewSalt()
{
    var salt = string.Empty;
    var random = new Random();
    for (var i = 0; i < 16; i++)
    {
        salt += (char)random.Next(Char.MinValue, Char.MaxValue);
    }
    return salt;
}

In almost all cases my salts contain characters with high character values. When I use this to hash passwords the hashes end up being the same with different salts.

private static string SaltAndHashPassword(string password, string salt)
{
    const int len = 64;
    const int parallel = 16;
    const int blockSize = 8;
    const int cost = 1024;

    var derivedBytes = new byte[len];
    SCrypt.ComputeKey(Encoding.ASCII.GetBytes(password), Encoding.ASCII.GetBytes(salt), cost, blockSize, parallel, null, derivedBytes);

    return new string(HexBase16.Encode(derivedBytes));
}

Is there something I am doing wrong or does the SCrypt algorithm not allow for characters over a certain range? When I limit the salt to (char)0 - (char)255 it works every time.

need neoscrypt,lyra2re,quark implementation.

Apparently no implementation to validate hashes

I find myself needing to reverse engineer this a little bit as I can't find a public function that allows me to validate an entered password against a known hash.

Needs update to 2.0

The official CryptSharp page already has 2.0 (well, for more than a year). It would be nice to update this repository with the current version of the source code (or visibly mark it obsolete, or whatever).

Vocabulary question

Are you encrypting the passwords or are you hashing them? Because when the API says 'test the crypted password against a potential password' I feel like running around in circles yelling about cats.