chorton2227 / maplelib2 Goto Github PK

What steps will reproduce the problem?
1. Star a new C# project, include MapleLib.
2. Make a for loop to loop through Mob.wz modifying bodyAttack, then setting 
ParentImage.Changed to true.
3. After the foor loop is done looping, run wzFile.SaveToDisk(fileName) and the 
error should show up, pointing to a NullReferenceException at 
WzCanvasProperty.write->write(bytes.length + 1)

What is the expected output? What do you see instead?
Expected: Saves the newly modified wz file.
Outcome: NullReferenceException found during the writing of WzCanvasProperty, 
as if the PngProperty(Image) is missing.

What version of the product are you using? On what operating system?
Latest Revision as of Nov 26, 2010, Visual Studio 2010 on windows XP SP3, and 
on Maplestory v92.

Please provide any additional information below.
Was going about making a quick little patcher to sort through the monsters that 
I would want to filter out in a PQ, setting the bodyAttack value to 0, and 
deleting the move properties, as well as setting lt/rb to 0. Might just be this 
old computer though, will test again on other computers.

What steps will reproduce the problem?
1. Take a look at GMS v137 Mob.wz
2. Look at some of the monsters
3. Some monster's animation will appear invisible (Orange Mushroom is an 
example)

What is the expected output? What do you see instead?
You should be able to see the images.

What version of the product are you using? On what operating system?
Not sure.
Using HaRepacker (the latest one) on Windows 8.

Please provide any additional information below.
N/A

What steps will reproduce the problem?
1. Export any WZ that has invalid characters in the data path.

Example:
Map.wz/Obj/etc.img/coconut/frontTime/:
Will produce:
coconut.fontTime.:.png
Which is not a valid file name.

What is the expected output? What do you see instead?
Output cannot be saved to the disk without changing it, so nothing is expected.

What version of the product are you using? On what operating system?
Revision 22
Microsoft Visual Studio 2010 Ultimate
Windows 7 64-bit

Please provide any additional information below.
Quick-fix in WzSerializer.cs for those interested:
string invalid = new string(Path.GetInvalidFileNameChars());
foreach (char c in invalid) currObj.Name = currObj.Name.Replace(c.ToString(), 
"_");

This will replace all invalid file name characters with an underscore. A 
problem will occur if there is Foo.Bar.:.png and Foo.Bar.|.png, as one will 
overwrite the other. Perhaps replacing the character with the dec/hex value 
would work better.

What steps will reproduce the problem?
1. Make a connnector
2. Let it connect to a GMS server
3. Let it getting pinged-out

What is the expected output? What do you see instead?
I expected to see a message of being disconnected.
I saw nothing.

What version of the product are you using? On what operating system?
Latest, Windows XP and Windows 7

Please provide any additional information below.
This:

            catch (SocketException se)
            {
                if (se.ErrorCode != 10054)
                {
                    Console.WriteLine("[Error] Session.OnDataReceived: " + se);
                }
            }


The if statement misses an else statement (which triggers the
OnClientDisconnected event)

Comments should be added to WzDirectory.cs. For example, what does the 
following lines of code do? I have been trying for 5 hours to work out what 
this does, but to no avail.

                if (type == 1) //01 XX 00 00 00 00 00 OFFSET (4 bytes) 
                {
                    int unknown = reader.ReadInt32();
                    reader.ReadInt16();
                    uint offs = reader.ReadOffset();
                    continue;
                }

What steps will reproduce the problem?
1. Open 992040000.img of Map.Wz

What is the expected output? What do you see instead?
Expected: Map information
Output: 
System.Exception: Unknown property type at ParsePropertyList


What version of the product are you using? On what operating system?
Using HaRepacker source with last maplelib2 source code. Visual Studio 2013. 
Win8.1 x64


Please provide any additional information below.

System.Exception: Unknown property type at ParsePropertyList: fieldLimit (128)
   en MapleLib.WzLib.IWzImageProperty.ParsePropertyList(UInt32 offset, WzBinaryReader reader, IWzObject parent, WzImage parentImg) en d:\Downloads\Maplestory\Sources\C#\hasuite\maplelib\WzLib\IWzImageProperty.cs:línea 149
   en MapleLib.WzLib.IWzImageProperty.ExtractMore(WzBinaryReader reader, UInt32 offset, Int32 eob, String name, String iname, IWzObject parent, WzImage imgParent) en d:\Downloads\Maplestory\Sources\C#\hasuite\maplelib\WzLib\IWzImageProperty.cs:línea 175
   en MapleLib.WzLib.IWzImageProperty.ParseExtendedProp(WzBinaryReader reader, UInt32 offset, Int32 endOfBlock, String name, IWzObject parent, WzImage imgParent) en d:\Downloads\Maplestory\Sources\C#\hasuite\maplelib\WzLib\IWzImageProperty.cs:línea 158
   en MapleLib.WzLib.IWzImageProperty.ParsePropertyList(UInt32 offset, WzBinaryReader reader, IWzObject parent, WzImage parentImg) en d:\Downloads\Maplestory\Sources\C#\hasuite\maplelib\WzLib\IWzImageProperty.cs:línea 142
   en MapleLib.WzLib.WzImage.ParseImage() en d:\Downloads\Maplestory\Sources\C#\hasuite\maplelib\WzLib\WzImage.cs:línea 277
   en HaRepackerLib.Controls.HaRepackerMainPanel.DataTree_DoubleClick(Object sender, EventArgs e) en d:\Downloads\Maplestory\Sources\C#\hasuite\HaRepackerLib\Controls\HaRepackerMainPanel.cs:línea 177
   en System.Windows.Forms.Control.OnDoubleClick(EventArgs e)
   en System.Windows.Forms.TreeView.WndProc(Message& m)
   en System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   en System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Load the midforest backgrounds and try to view the basic sky background (no = 0)
All you see is a bunch of weird black and white stripes.
I've taken the liberty of fixing this issue in my own wzlib so here is the C++ 
code that I use.
Feel free to port it back over and fix your own code.
Buf1 and Buf2 are just pre-allocated arrays of uint8_t.

    case 517:
        {
            uint32_t len = sprite.data->width*sprite.data->height/128;
            Decompress(length, len);
            for (uint32_t i = 0; i < len*2; i++) {
                uint8_t b4 = (Buf1[i*2]&0x0F)|((Buf1[i*2]&0x0F)<<4);
                uint8_t b3 = (Buf1[i*2]&0xF0)|((Buf1[i*2]&0xF0)>>4);
                uint8_t b2 = (Buf1[i*2+1]&0x0F)|((Buf1[i*2+1]&0x0F)<<4);
                uint8_t b1 = (Buf1[i*2+1]&0xF0)|((Buf1[i*2+1]&0xF0)>>4);
                for (uint32_t j = 0; j < 256; j++) {
                    Buf2[i*1024+j*4] = b1;
                    Buf2[i*1024+j*4+1] = b2;
                    Buf2[i*1024+j*4+2] = b3;
                    Buf2[i*1024+j*4+3] = b4;
                }
            }
            glTexImage2D(GL_TEXTURE_2D, 0, 4, sprite.data->width, sprite.data->height, 0, GL_RGBA, GL_UNSIGNED_BYTE, Buf2);
            break;
        }