Have ProgressBar implement Read instead of Reader about pb

[cheggaaa]

Can you give an example of?
ProgressBar has proxy reader.
For example:
var myReader io.Reader
myReaderWithProgress := bar.NewProxyReader(myReader)

[joshlf]

Oh, I see. I thought the user was responsible for putting the ProgressBar in the Reader. If the user isn't supposed to touch the Reader type, you might want to make it unexported. You could still return it as an io.Reader interface type from NewProxyReader().

[joshlf]

Wait, nevermind; they need to be able to access package-specific options. Still, it might be a good idea to have NewProxyreader return a ProgressBar with a Read method instead of a Reader with a member variable ProgressBar.

[cheggaaa]

Yes, but ProgessBar has a required parmeters, like Count.
It's may looks like this:
pb.NewReaderBar(myReader, count)
// set options (if you need)
pb.Start()
// and your stuff here

[joshlf]

Yeah, that's the sort of thing I was thinking.

[jszwedko]

Yeah, that seems reasonable, for new I just use io.TeeReader.

[Lupus]

I found NewProxyReader by chance via looking into this issue. It's worth mentioning it in readme along with MultiWriter approach for io operations.

BTW greate library! keep up the good job!