Comments (2)
the other option I'm thinking about is extending ProxyReader to just handle Seek calls like it handles Close calls, but always return an error if you call Seek() on something that isn't a Seeker underneath. this would mean less code, both in the implementation and in the io_test.go
. feedback appreciated!
from pb.
We can't just add Seek to the reader. Some packages can take io.Reader in arguments, but inside do a type check for io.Seeker - in this case, we can mess up the logic.
ProxyReaderSeeker is a solution, but with Seek, it is impossible to correctly calculate the progress (speed, remaining time, etc.) I think it's ok and users will keep this in mind.
from pb.
Related Issues (20)
- Elapsed Time HOT 1
- Version Error HOT 1
- Not display console HOT 4
- Progress bars rendering is disturbed when terminal screen size is small
- How can I clean the process bar before I want to output something. HOT 6
- It is "go get github.com/cheggaaa/pb/v3" error?
- Spinner HOT 2
- Flag to disable the counter total output HOT 1
- [Question]: How to use more colors? HOT 1
- Incorrect values of downloaded and percentage HOT 1
- possibility to update ProgressBar from worker pool HOT 3
- [QUESTION] How to get multiple/single progressbars for concurrent processes ? HOT 1
- Progress additional text at speed section incorrect work HOT 2
- Building Windows binary on 3.1.3 fails HOT 1
- Disable when no TTY? HOT 2
- ProgressBar Pool on Windows: Inconsistent printing on Windows when using ProgressBarTemplate HOT 4
- Copyright confusion HOT 2
- How to display a progress w/ speed that slower than one item per second?
- Nested loop printout HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pb.