checkout / link_checkoutcom Goto Github PK

Please rename this template file using the actual name of the APM: "payPal.isml".

The pre authorisation response for card payments always returns true. Please implement an effective test of the 0$ auth response returning true or false.

All language strings used in the code should be referenced in this .properties file.

The processor ID defined here doesn't match the one declared in payment-methods.xml for alternative payments

"request" is a reserved name in the SFCC system and is used as a global variable in the system. It should not be used to name custom variables as it will override the global variable and make it unaccessible. Please rename.

Rename this file to "apm.js" and its parent folder to "apm".

The APM custom preferences seem to have disappeared. Please add them back and:
1- Put all the APM parameters in a single separate group as it's currently done for Account Keys, Apple Pay, Google Pay and general settings. The APMs group should be named "Checkout.com APM".

2- Link the custom preferences parameters to each APM involved.

Please make ckoStorefrontController and ckoStorefrontCore custom preferences config fields optional.

The currency codes for gateway request value calculation should be moved to a JSON file.

Please make the string translatable.
The first letter of the comment should also be a capital letter.

The processor ID defined here doesn't match the one declared in payment-methods.xml for card payments

Please rename this template file using the actual name of the APM: "benefitPay.isml".

Rename all occurrences, spaced and camel cased combinations of "Secrete Key" to "Secret Key" in the branch, according to the Hub wording.

"apm" already contains the word "payment", which makes "apm_payment_types" a repetition of the word "payment". Please rename all occurrences of this variable to "apm_list".

Please make the string translatable.

Please move all inline CSS styles to a separate CSS file.

"request" is a reserved name in the SFCC system and is used as a global variable in the system. It should not be used to name custom variables as it will override the global variable and make it unaccessible. Please rename.

The billing descriptor fields should not be mandatory in the site preferences. It's currently impossible to save the configuration form without providing values.

After making these fields optional, the part of the payment request handling billing descriptors should also make sure the fields are not empty before being added to a payment request

Please make sure every code comment starts with a capital letter in this file. Ex:
// My comment instead of // my comment.

The saved card feature needs porting for card payments. The code is available in the existing certified cartridge.

Naming conventions should be strictly followed. The fist letter of exported/Public function names should be a capital letter. Please update the exported function name and all calls to the function in the code base.

Please rename this template file using the actual name of the APM: "przelewy24.isml".

This utils.js file should be moved to the helpers folder and follow the existing naming conventions.
Suggested name: CKOUtilities.js
Suggested folder: /scripts/helpers

Rename this file to "apm.isml" instead of "APM.isml"

"session" is a reserved name that shouldn't be used for function naming. "session" is a global SFCC variable that could collide with other functions or variable using the same name, an. create unexpected behaviour.

Please explicitly restrict the export method to an http method (POST or GET)

This string should not be hard coded. Please move it to an attribute-definition tag in system-object-definitions.xml, without assign it to an attribute-group so that it's not displayed on the UI.

The string will still be retrievable using the ckoUtility.getValue() method.

Rename all occurrences, spaced and camel cased combinations of "Private Key" to "Private Shared Key" in the branch, according to the Hub wording.

Please implement standard translation for all strings in this file.

This string should be translated using the .properties system.

Please use the actual names of the APMs in all languages strings, and respect the case of the brand.

Example in this file:
"cko.bancontact.name" should have the value "Bancontact" and not "BANCONTACT PAY".
The actual name of each APM is available here: https://docs.checkout.com/docs/payment-methods

Please implement translation for all language strings in this file.

Please move JS inclusions to the bottom of the file.

Reminder to please read true the current cartridge documentation - There are some areas that need your attention, for either improvement or completion.

HTML tags should be lowercase. "h4" and not. "H4". See HTML standards.
Please double check all APM templates files as fawry.isml for example has the same issue.

Please rename this template file using the actual name of the APM: "giropay.isml".

Please make sure:
1- Every function starts with a lower case letter. Ex: myFunction() instead of MyFunction()
2- Every code comment starts with a capital letter. Ex: // My comment instead of // my comment
3- Every comment is relevant to the APM method processed. "multibanco" seems to be used as comment in many places for APMs that are not Multibanco.

A reminder to edit the cartridge documentation to update the cartridge version and release date

Please make the string translatable.

Rename this file to apm.js and rename the "toggleAPMS" method to "toggleApm".

Please make the expiration year select list values dynamic in the card payment form. All options of the select list should be populated dynamically - from now + 10 years - using a js loop.

Please translate the "Edit" string and use the name of. the APM the alt attribute.
Example:
alt="${Resource.msg('cko.bancontact.name','cko',null)}"
value="${Resource.msg('cko.button.edit','cko',null)}"

This has to be done for all APMs in all templates.

The "PAY WITH CARD" string needs to follow the translation rules

Business address line 2 should not be compulsory in the custom preferences fields defitions

All alternative payments displayed should be filtered according to the currencies they support.
It is necessary to add a son file with currencies supported for each APM, and check that file before displaying an APM.

Example here for the Magento 2 integration:
https://github.com/checkout/checkout-magento2-plugin/blob/master/etc/apm.xml

This method should be named "handleApmChargeResponse" and not "handleAPMChargeResponse". Please replace all references to this method according to camel case naming conventions.

The APMs tab content should be loaded on page load. Please remove the tab click event.

The 0$ pre authorisation of a card is failing systematically please check.

Please avoid sample data in the code

The Klarna script seems to be looking for a file that doesn't exist on the Klarna server: