Errors when using 3.4.1 about frames-ios

[harry-brown-cko]

Hey @sebskuse , sorry to hear that you're having issues with Frames again. We've unembedded the frameworks from Frames in the develop branch. Can you please check if this has fixed your issue? If so we can do a release that includes this fix.

NB. Code in develop is not verified for production and should not be pushed to customers.

[sebskuse]

Hi @harry-brown-cko, I'll pull develop in as a dependency and smoke test that against CI and the AppStore - will let you know how we get on

[sebskuse]

Hey @harry-brown-cko, given that a go (resolves to commit 698046f).

I'm getting a compilation error with this now:
could not find module 'Frames' for target 'arm64-apple-ios'; found: armv7-apple-ios, arm, armv7

It looks like the xcframework architectures being built don't match what we were seeing with the older version (and other Carthage dependencies - it looks like arm64 is being omitted somewhere?):

I also notice that we are now required to link CheckoutEventLoggerKit in our app. As you're probably aware, each dynamic framework an app links slows down app startup time - we're now at 4 dynamic frameworks for Frames (Frames, Alamofire, PhoneNumberKit, CheckoutEventLoggerKit). This appears to be an internal dependency, so doesn't feel right exposing this to the consumer application - maybe a static library makes more sense if you're looking for code separation? That way you can separate the code into a separate framework, but it gets compiled down into a single binary Frames for the consumer.

[harry-brown-cko]

Hey @sebskuse I think the issues you mentioned are now fixed. Would you mind checking the develop branch again? Thanks in advance!

[sebskuse]

Hi @harry-brown-cko, thanks for the update - I've updated our branch to the latest commit on develop (df9c3f1) and it looks like everything has compiled correctly and tests have passed, so looks good!

[harry-brown-cko]

Thanks @sebskuse for being patient with us whilst sorting out this issue. Closing it now and we expect the fixes to go out in the next release

[sebskuse]

No problem, thanks for sorting.