Comments (5)
Hi @alex-ioja-yang-cko and @nberthelot,
At the moment, we have solved the problem through our private repo for the spec repo.
In our project, there are dependencies that are no longer supported by CocoaPods. With the help of our private spec repo, we can add support ourselves.
Regarding PhoneNumberKit, we took a subspec for version 3.5.8 and changed the version to 3.3.3. This allowed us to use the latest version of PhoneNumberKit and get rid of the bug.
Our team understands that this is a temporary solution, but we currently don't have the resources to move to SPM, although we would very much like to.
I think in 1-2 months, we will fully switch to SPM, which will eliminate problems like this.
In any case, thank you for your help,
Dmitry
from frames-ios.
Hi @barniques,
Thank you for flagging this to us. You are correct, PhoneNumberKit has reached 3.5.8 and our CocoaPods distribution is lagging behind by having fixed 3.3.3.
We will discuss this internally and I am confident we will aim to improve soon. But as these processes may take a longer time, I have looked up the SwiftPackageManager distribution and importing it that way resolves the dependency locally to the latest 3.5.8.
To avoid being blocked by our release, would trying Swift Package Manager for the dependency be of any help to your team? We have tried SPM over many different setups and it should work seamlessly alongside CocoaPods so there should be no negative impact on your project or other dependencies.
If you could please let us know whether this may be an immediate solution it for your team and we will aim to come back with an update once we review how we may fit this change on the product development.
Have a great evening,
Alex
from frames-ios.
Hi @barniques,
A small update from our side.
Whilst working on a new feature that will also allow us to update the dependency, we did find that PhoneNumberKit latest Cocoapods release is actually 3.3.4, from last year (as found in Cocoapods repo).
This means that whilst in an upcoming release we will be removing the "fixed version dependency" as you suggested, simply relying on Cocoapods to get the correct version may not work (although I am not familiar with Cocoapods & SPM ability to interlink).
There is however an issue opened on PhoneNumberKit that is also requesting a new release to Cocoapods.
In the meanwhile, if SPM has helped fix your issue, happy to hear any feedback,
Thank you,
Alex
from frames-ios.
Hi @alex-ioja-yang-cko ,
Thank you for your update do you have an ETA about the fix ?
Thank you
from frames-ios.
Hi @nberthelot,
I'm afraid I wouldn't be able to offer an ETA right now, as any release will be subject to Product and has implications beyond the setup we are looking at here. It would be best to reach out to your company's operations contact for estimates.
However, given the Cocoapods spec update would only unlock PhoneNumberKit via Cocoapods to 3.3.4
, is this still a blocker for you? It looks that the latest versions are still not available outside of SPM. And using Frames via SPM will already use these later versions regardless.
Let me know if there are other complexities or info I am missing, as it might help us to scope and ensure its included in upcoming release.
Thank you,
Alex
from frames-ios.
Related Issues (20)
- Frames Cocoapod integration is broken from 4.0.2 HOT 5
- merchant certificate not found HOT 4
- Localisation UI issue in TextField Alignment HOT 7
- Back Button and Accepted Cards not showing on TestFlight Build HOT 4
- Does headless mode have been removed in 4.0 ? HOT 4
- Support of alternative payment methods HOT 1
- Text color in Text fields isn't updated after changing Light/Dark mode HOT 4
- 3ds redirection not working HOT 2
- Remove Billing Info (name , address etc) from form.
- Expiry date textfield doesn't append '/' which lead to invalid date format error - Frames 4.0.4, Xcode 14.3 HOT 2
- Expiry date textfield doesn't append '/' which lead to invalid date format error - Frames 4.0.4, Xcode 14.3 HOT 1
- Users can submit the Pay button twice before 3DS view pops up HOT 4
- Support for app extension HOT 7
- Crash when use payment view HOT 15
- Problem with customisation. HOT 18
- Payment page alignment or text based on language switching is not updating HOT 5
- apple pay token got card_expired error HOT 1
- Crash with Apple Pay and version 4.3.3 of Frames and 2.0.3 of Risk SDKs HOT 19
- Issue with Cardholder Name validation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frames-ios.