chaostoolkit-attic / chaosplatform-grpc

Chaos Platform gRPC library

Chaos Platform gRPC Library

This is the authentication service of the Chaos Platform.

Purpose

• Provide gRPC client stubs for the Chaos Platform services
• Provide gRPC server stubs for the Chaos Platform services

Content

• Install
• Generate from the protobug definitions

Contribute

Contributors to this project are welcome as this is an open-source effort that seeks discussions and continuous improvement.

From a code perspective, if you wish to contribute, you will need to run a Python 3.5+ environment. Then, fork this repository and submit a PR. The project cares for code readability and checks the code style to match best practices defined in PEP8. Please also make sure you provide tests whenever you submit a PR so we keep the code reliable.

The Chaos Platform projects require all contributors must sign a Developer Certificate of Origin on each commit they would like to merge into the master branch of the repository. Please, make sure you can abide by the rules of the DCO before submitting a PR.

chaosplatform-grpc's Issues

README wrong?

The README states that this module

is the authentication service of the Chaos Platform.

I think that is wrong?

Loosen the version constraint of grpcio to avoid dependency conflicts

Hi, chaosplatform-grpc locked the version constraint of grpcio as grpcio==1.17.1, which leads a troubling scenario to its direct downstream project chaosplatform-account which has dependency grpcio.

What makes the situation worse is that the downstream projects [chaosplatform-auth, chaosplatform-experiment, chaosplatform-scheduler] of chaosplatform-grpc are also have dependency grpcio.

Could you please loosen the version constraint of grpcio?
Benefit of this is that users using both of chaosplatform-grpc and grpcio can upgrade their third party libraries in a timely manner to reduce technical debts.

Solution

The dependency trees of your project and affected downstream projects are shown as follows.
Taking the version constraints of upstream and downstream projects into comprehensive consideration, you can

1. Loosen click to be grpcio >=1.17.1.

2. Try to add an upper bound for grpcio’s version constraint, according to your compatibility.

@Lawouach Please let me know your choice. I can submit a PR to fix this issue.

Thanks for your attention.
Best,
Neolith