champo / tpe-paw Goto Github PK

After invalidating the session in the logout, it is not necessary to remove the user attribute from there

Make sure both create.sql and changelog.sql are up to date. Also create a new version of insert.sql

Currently images are stored in the fs, they should be stored in the db

Change the log4j config to log errors to a file to be able to debug in tomcat (the not-embedded one).

Operation type and property type should be enums, not simple ints

The 6 services, modeled as 6 bools should be an enum representing each of them then using a list of those

The following functions should receive a whole object, not just an id:

-PictureService.getByPropID
-PictureService.delete
-PictureService.getProperties
-PictureService.checkOwner
-PictureDAO.delete
-PropertyDAO.getProperties
-PropertyDAO.checkOwnership

(check other methods)

the autocommit atributte in the connection object should be false

It seems that there is an issue with the Permission Filter and the redirect that its doing. The user is logged correctly but the redirection fails and throws an Exception. It seems to happen only when coming from "/" (localhost:9090).

When submiting a property form empty, I get several of:

The field 'price' has to be a positive number under MAX_VALUE.

If there is a problem with the database connection it shous a NPE on every page. You should see a more friendly message

Extremely simpl just add criteria.addOrder(Order.asc("id")); in the getProperties method of PropertyHibernateDao.

This 2 classes should check that 2 beans are not instantiated twice (due to concurrency problems)

Spring servlet is catching the requests to static content such as css, images, etc... We need a way to by pass it.

We should create an Entity class which only has an ID. Every other entity extends from this class.

That.

There is no style right now. We should spice things up with a little bit of css magic

The login form needs the remember me feature.

Property (I think this same thing is happening in pictures) should validate the data in the services when updating

It's functionality should be done by propertyService. Same happens with PictureDAO

The register link in the login page is broken (it is an absolut link)

See title.

The login form needs the remember name feature.

Right now the DB connection values are hardcoded. They need to be loaded from a config file.

The alter table for the extension column is missing.

What the Dude says.

Currently the DB user is paw1. It should be paw

Pictures should have a Property not a propertyId

Properties should have a User not a UserID

The existence of a user is checked in the dao by catching an exception and analyzing it.

The correct query should be done to check the existance and then the insert

There should not be default constructors. This applies for clases Picture, Property and User

These should be fully implemented in the service considering a Property holds a complete reference to the user

You should have the option of ordering properties by price. Asc and desc

I created a property, and it was published. I then edited the property, and the property was suddenly unpublished.

Your user has been successfully registered! was shown on the page but tomcat says:

29 [http-9090-1] WARN ar.edu.itba.paw.grupo1.dao.JDBCUserDao - Caught SQLException while trying to register user.
org.postgresql.util.PSQLException: ERROR: permission denied for relation users
at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2062)
at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1795)
at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:257)
at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:479)
at org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:367)
at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:360)
at ar.edu.itba.paw.grupo1.dao.JDBCUserDao.register(JDBCUserDao.java:43)
at ar.edu.itba.paw.grupo1.service.UserServiceImpl.register(UserServiceImpl.java:30)
at ar.edu.itba.paw.grupo1.controller.RegisterServlet.doPost(RegisterServlet.java:52)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at ar.edu.itba.paw.grupo1.filter.SessionFilter.doFilter(SessionFilter.java:62)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:602)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
at java.lang.Thread.run(Thread.java:679)

Show a banner across a property's images when its reserved

There should be a class representing the filters state when performing a search.