chaitanyagupta / chronicity Goto Github PK

Please consider adding :description, :author and :license information to your ASDF system(s). This will greatly help Quicklisp users and make it easier for them to report bugs.

More information:

http://blog.quicklisp.org/2015/05/looking-for-more-metadata.html
https://www.quicklisp.org

`(chronicity:parse “a month ago” :now (chronicity:make-date 2009 5 31))` signals an error. Ideally it should return 2009-04-30T00:00:00 or 2009-05-31T00:00:00.

More specifically, this is the problem (eval in CHRONICITY package): `(datetime-decr (make-date 2009 5 31) :month)`

When running the tests, I am seeing 3 execution errors as shown here:
http://paste.pocoo.org/show/285515/ in CCL trunk.

Environment:

Welcome to Clozure Common Lisp Version 1.6-dev-r14397M-trunk (DarwinX8664)!

uname -a

=> Darwin Victoria.local 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386

“Second” can either refer to the unit of time or the ordinal 2nd. Right now, we just assume it is the unit of time and ignore the ordinal.

A possible fix for this is to preprocess the tokens (before calling TOKENS-TO-SPAN) and tag any “second” followed by a repeater to be the ordinal 2nd.

It seems that only English is supported, right? Would it be easy to expand for other languages?

Current local-time implementation leads to BST being mapped to historical Samoa subzone instead of British summer time. I've opened a pull request dlowe-net/local-time#89 to address this issue in local-time.

Please review and use new public API when PR is merged.

DATETIME-MONTH+ uses LOCAL-TIME::INVALID-TIME-SPECIFICATION which is an unexported symbol in the local-time package. Either get the maintainers of local-time to export it or do something else. Cannot make a new release till this is fixed.

parsing "today" or "this day" return now and not the day of now.

(chronicity:parse "today" :now (local-time:encode-timestamp 0 0 30 12 13 2 2020))
@2020-02-13T12:30:00.000000+01:00
(#<CHRONICITY::TOKEN this [GRABBER] {1004470383}>
 #<CHRONICITY::TOKEN day [REPEATER-DAY] {10044703C3}>)