cgkineo / adapt-contrib-menubox Goto Github PK

The js is looking for a JSON object called _boxMenu - should this be unique?

Requires:

adaptlearning/adapt-contrib-core#366

How would be handle locking if there are multiple instances of menuBox component?

Requires:

adaptlearning/adapt-contrib-core#366

Header js in MenuBoxView is no longer required as the menu header has been removed

Requires:

adaptlearning/adapt-contrib-core#366

We probably don't even need menu background js in MenBoxView as the menu will now be sitting in its own block

Requires:

adaptlearning/adapt-contrib-core#366

As this is now a component, theoretically we don't need groups functionality, although I'm assuming we can add multiple instances to the page?

If this is the case, suggest adding a component header. This will provide the same functionality as groups and allow components to sit between menu items.

Requires:

adaptlearning/adapt-contrib-core#366

I can see this got carried over from Boxmenu however I don't think this is needed. We typically use menu groups for two reasons:

1. Bespoke layouts - if you want to wrap menu items in containers to give more flexibility in the styling of menus (grid layouts).
2. Section up content.

For both instances, we can do this by using multiple menuBox components. Blocks give us the flexibility with the layout as well as breaking up the menu structure (grouping content).

I've yet to test the group functionality with the Introduce Menus as Pages PR as I wanted to query this before doing so. From a setup perspective, I think I would find it easier to think of menuBox as a component and use blocks for structure rather than enabling the group config I associate with Boxmenu.

Using blocks to group items rather than the group config would give us more flexibility with menu design too e.g. displaying other components between menu items.

I'm not sure what the impacts are with menu locking/completion etc so this will need consideration.