cerisara / dragongoapp Goto Github PK

I just accidentally hit the resign game button and it resigned me without a confirmation dialog. The absence of a confirmation in this context can clearly have significant consequences. Therefore, I think this probably constitutes a bug rather than a feature request. I am happy to help in fixing it but I might need a few pointers of where to look in the source code first.

When you look at an old serialized version of a ladder, and you challenge someone, and if the ladder has changed since the last time you downloaded it, it may result in effectively challenging another user than the one you were targeting. TODO: double-check that the user id shown in the app and challenged in the site is the same.

In the latest APK download, on the login screen there is a DGS button and an OGS button. I guess OGS refers to online-go.com? I entered my DGS credentials and hit the DGS button first, then I entered my OGS credentials and hit the OGS button but I only have DGS games showing in the app. Is there a plan to support OGS too? That would be amazing, to have both sites in one app! Can I help with this feature in any way? Thanks :)

Since recently, I need to press two times on the "get games" button to actually download the games, and there is systematically a "connect error" window. It's not a big issues, because the games are actually downloaded when I press two times the "get games" button, but it's a bit annoying.
I guess it may be because the first press cannot connect, while the second press can.
Need to track down in the logs what actually happens with the connections.

Hi, I installed the apk from http://talc1.loria.fr/users/cerisara/DragonGoAppv2.apk

Before I had entered any DGS credentials, I tapped the "..." button in the top right.

The application crashed.

Some days the app just shows text instead of the game I am playing:

On recent android, "ask for confirmation" windows appear when moving on the board, which they shouldn't.
It's not that bad, because one can always press "cancel", but it's really annoying.
Gonna get a look soon at this...

Hi!

I'm using the v1.10 version of this app on android 7.1.2.
I want to login to dgs, but I can't find the menu/settings that is required to do it.

Dear developers,

We have recently developed a state-of-the-art static analysis tool for uncovering API compatibility issues in Android apps. Applying this tool to open source apps on F-droid, we have exposed a few instances of compatibility issues and submitting them to development teams for a fix.

For your app, we have found that this project has accessed the following APIs which are available only on an API level higher than the declared minSdkVersion and which are accessed without proper protection. In other words, if those APIs get called at runtime, it will trigger a NoSuchMethodError and thus result in a crash of the running application.

<org.json.JSONObject: java.lang.Object wrap(java.lang.Object)>:[19,25]
<java.lang.String: boolean isEmpty()>:[9,25]
<org.json.JSONArray: void (java.lang.Object)>:[19,25]

Note that, because of the nature of the static analysis, we cannot confirm whether the flagged APIs would actually be called at runtime (e.g., unreachable code). However, we still believe that those APIs, which may cause compatibility issues, should not be accessed or at least be accessed with proper protections.

In addition to the aforementioned APIs (i.e., backward-compatibility), which could cause app crashes if accessed, we have also identified that this project has also accessed some APIs that have been removed from the latest public SDK, making the app possibly suffer from forward-compatibility issues.

<org.apache.http.HttpResponse: org.apache.http.StatusLine getStatusLine()>:[1,22]
<org.apache.http.params.BasicHttpParams: void ()>:[1,22]
<org.apache.http.HttpResponse: org.apache.http.HttpEntity getEntity()>:[1,22]
<java.lang.reflect.Array: java.lang.Object newInstance(java.lang.Class,int[])>:[1,8]
<org.apache.http.HttpMessage: org.apache.http.Header[] getAllHeaders()>:[1,22]
<android.net.http.AndroidHttpClient: org.apache.http.conn.ClientConnectionManager getConnectionManager()>:[1,22]
<org.apache.http.client.methods.HttpPost: void (java.lang.String)>:[1,22]
<org.apache.http.client.HttpClient: org.apache.http.HttpResponse execute(org.apache.http.client.methods.HttpUriRequest)>:[1,22]
<org.apache.http.Header: java.lang.String getValue()>:[1,22]
<org.apache.http.protocol.HttpContext: void setAttribute(java.lang.String,java.lang.Object)>:[1,22]
<android.net.http.AndroidHttpClient: android.net.http.AndroidHttpClient newInstance(java.lang.String)>:[8,22]
<org.apache.http.client.HttpClient: org.apache.http.conn.ClientConnectionManager getConnectionManager()>:[1,22]
<android.net.http.AndroidHttpClient: org.apache.http.HttpResponse execute(org.apache.http.client.methods.HttpUriRequest)>:[1,22]
<org.apache.http.client.methods.HttpGet: void (java.lang.String)>:[1,22]
<org.apache.http.HttpEntity: java.io.InputStream getContent()>:[1,22]
<org.apache.http.message.BasicNameValuePair: void (java.lang.String,java.lang.String)>:[1,22]
<android.net.http.AndroidHttpClient: void close()>:[8,22]
<org.apache.http.HttpMessage: org.apache.http.Header[] getHeaders(java.lang.String)>:[1,22]
<org.apache.http.client.methods.HttpEntityEnclosingRequestBase: void setEntity(org.apache.http.HttpEntity)>:[1,22]
<org.apache.http.conn.ClientConnectionManager: void shutdown()>:[1,22]
<org.apache.http.impl.client.DefaultHttpClient: void (org.apache.http.params.HttpParams)>:[1,22]
<org.apache.http.protocol.BasicHttpContext: void ()>:[1,22]
<org.apache.http.client.entity.UrlEncodedFormEntity: void (java.util.List,java.lang.String)>:[1,22]
<org.apache.http.impl.client.BasicCookieStore: void ()>:[1,22]

We would be very much appreciated if you can acknowledge to us that those reported APIs are indeed problematic for the project’s long-term stability. please let us know if you need any more information relating to this issue report.

TODO

always:

• loss state android fragment

when adding red-X:

• option to reset all X
• option to get out of this mode
• prevent from creating variations
• impossible to score without putting any X
• update message: "SEND" is now "SCORE"

when showing territories:

• cross-marked groups of stones are not shown as W/B territory; are they counted ? YES
• prevent from clicking on the board (which adds a stone) at this stage
• option to get out of this mode
• show the score in the label

I downloaded the apk from http://talc1.loria.fr/users/cerisara/DragonGoAppv2.apk and installed.

Then I chose the menu, Settings.

I entered my username and password, but received an error saying it was unable to log in. I tried it a few times so I am fairly sure I got the password right!

The error message almost implied to me that it was trying to use the username as the password...

Hey. Good job making an OS DGS client :)

Is this on Google Play at all?

Crash or loose goban when rotating view.
For now, please don't rotate the view in the app.
I'll have a look at that when I'll have some time...

When receiving a result message (time-out, resign...) it'd nice to be able to automatically download and open the corresponding game.

Sometimes, the "waiting window" just does not show up.
This seems to happen after "closing" the app, but there's still some process running in the background, and the next time the app is launched, this bug occurs. For now, to avoid this bug, this may need to clear the RAM, or wait for a long time before starting the app again. But I should do a better clean-up when exiting.