centerforopenscience / django-elasticsearch-metrics Goto Github PK

See https://github.com/sloria/django-elasticsearch-metrics/pull/5/files#r205802781

...for symmetry with pre_index_template_create

cc @mfraezz who will need this for the impact notifications feature.

*sync_metrics? sync_metrics_templates?

• Django has a way to autodiscover modules. https://github.com/sabricot/django-elasticsearch-dsl/blob/master/django_elasticsearch_dsl/__init__.py#L11

Running tox -e lint currently fails locally:

GLOB sdist-make: /Users/sloria/projects/cos-projects/django-elasticsearch-metrics/setup.py
lint installed: aspy.yaml==1.1.1,cached-property==1.4.3,cfgv==1.1.0,identify==1.1.3,nodeenv==1.3.2,pre-commit==1.10.4,PyYAML==3.13,six==1.11.0,toml==0.9.4,virtualenv==16.0.0
lint runtests: PYTHONHASHSEED='3872058292'
lint runtests: commands[0] | pre-commit run --all-files --verbose
[black] black............................................................Passed
hookid: black

All done! ✨ 🍰 ✨
13 files left unchanged.

[flake8] Flake8..........................................................Failed
hookid: flake8

elasticsearch_metrics/management/commands/sync_metrics.py:1:1: F401 'django.core.management.base.CommandError' imported but unused

But Travis is still passing.

See #5 (comment)

Any test marked with es should automatically trigger cleaning up the ES environment.

Add a command to check if ES templates exist for all templates. It should exit with an error if ES templates are not in sync.

We'll need this to prevent our app servers from deploying before metrics have been synced.

Add a mgmt command, show_metrics to pretty-print a list of all registered metrics.

Might be nice to have optional factory_boy integration, to make it easier to generate fake data in tests.

import factory

from elasticsearch_metrics.factory import MetricFactory

class PreprintDownloadFactory(MetricFactory):
    user_id = factory.Faker("lexify", "?????")

PreprintDownloadFactory()  # indexes a test metric

• Can we do this transparently? Or do we need to have a Date subclass?

Integrate with curator for cleaning out metrics' indices:

python manage.py clean_metrics osf --time-unit days --older-than 45