cemalgnlts / mailjs

This repo allows you to automate the registration process at the various sites which do require email confirmation for testing purposes.

Hi there 👋

My name is Cemal (@cemalgnlts), I am a 24 year old developer from Türkiye (🇹🇷). I mostly do Web Developement.

mailjs's Issues

Publish rpm package

It might be a good idea to release a package to npm or GitHub packages

createOneAccount() types are not correct

I'm new to TypeScript, so I'm not sure if this is a bug.
When I try to access the returned object of createOneAccount(), it doesn't recognize the data.username, just the data.

async createEmail() {
  const mailAccount = await this.mailJS.createOneAccount();
  return mailAccount;
}

Setting a token

Hi, I was wondering if would it be possible to create a method to set the token? Currently, the token has a private type so you can't override it. I want to do this because then I can store the token in localStorage and reauthenticate with the client, keeping the user signed in and not having to login every time. (p.s. not sure how long the JWT token actually lasts for, so it may not be ideal.)

Let me know what you think and if there's another way to keep the user logged in.

Failed to execute 'fetch' on 'Window': Illegal invocation

It gives this error in browsers, it may be related to rollup.

Failed to execute 'fetch' on 'Window': Illegal invocation

The first version can be used until the error is resolved.

<script src="https://cdn.jsdelivr.net/gh/cemalgnlts/[email protected]/Mailjs.min.js"></script>

Make eventsource.min.js really optional

The README says this about eventsource.min.js:

<!-- you can exlude this if not listening to events (may cause runtime error) -->

But the way it is bundled, it always throws an EventSourcePolyfill is not defined error even if you don't use events.

You should change the output.globals.eventsource rollup config value from EventSourcePolyfill to globalThis.EventSourcePolyfill so it just resolves to undefined when missing instead of throwing an error. Then indeed the error will only happen when you try to use events and not every time.

Latest version does not work for browser

The quickstart code from the readme gives errors when ran in a browser.
The code:

<script src="https://cdn.jsdelivr.net/gh/cemalgnlts/Mailjs@latest/mailjs.min.js"></script>

<!-- you can exlude this if not listening to events (may cause runtime error) -->
<script src="https://cdn.jsdelivr.net/gh/cemalgnlts/Mailjs@latest/eventsource.min.js"></script>

<script>
	const mailjs = new Mailjs();
</script>

The errors: Uncaught ReferenceError: EventSourcePolyfill is not defined on line 1 of mailjs.min.js and Uncaught TypeError: Mailjs is not a constructor on line 6 of the example code.

The example in the examples folder works fine. This is because that example uses version 2.0. Changing "latest" in the quickstart code to 2.0 makes it work. But then I'm unfortunately missing out from the new features in 2.2.

CDNs do not include mailjs.min.js built for use in browser

Check out https://unpkg.com/@cemalgnlts/mailjs/ or https://cdn.jsdelivr.net/npm/@cemalgnlts/mailjs/

They are pretty barebones compared to the git repo, because of the files field in the package.json. Most notably, they lack the mailjs.min.js needed for use in browsers.

In the README example for use in browser, you give a jsdeliver link that uses special syntax for the github repo instead of the npm package, but people searching for the module on the cdn normally may not think to do so.

Perhaps you should add mailjs.min.js to files and/or browser field and/or move it to dist folder to make the module more easily usable in browsers without people having to look up the example with using jsdeliver special syntax for github?

expose response status code in IResult

Hi! Thanks for the great library!

I think it would be great if the IResult would also expose the response status-code as currently it's pretty hard to debug why a request is failing.

Delete Multiple emails

If I have to delete many emails, I had to delete one after the other.

Can batch deletion be implemented? Just an enhancement to the system.

Nice job.

handle rate-limit errors internally

Currently when I get rate-limited, I get this result { status: false, message: undefined, data: '' }.

I'd suggest the client handles rate limits internally by retrying the request after 1s

Can't the same account be created again after the DELETE /accounts/{id} interface is invoked to delete the account?

Can't the same account be created again after the DELETE /accounts/{id} interface is invoked to delete the account?

ReferenceError: fetch is not defined in Nodejs

    const res = await fetch(this.baseUrl + path, options);
                ^

ReferenceError: fetch is not defined

please add node-fetch