cefsharp / cefsharp.dom Goto Github PK

New SetPropertyValueAsync and SetValueAsync methods were added, look at adding the equivalent Set versions to avoid having to write.

Simple helper methods to make it easier (it's already possible).

https://docs.microsoft.com/en-gb/nuget/nuget-org/package-readme-on-nuget-org

Current plan is to publish packages under the name CefSharp.Puppeteer.

• Publish to AppVeyor Nuget Feed
• Publish to Nuget.org

hardkoded@664ca05

• Renamed Page to DevToolsContext
• Added obsolete Page class that inherits from DevToolsContext for backwards compatibility

CefSharp.Puppeteer.DevToolsContext will replace CefSharp.Puppeteer.Page as the main entry point. I think overall this makes more sense as the concept of a Page is a little strange in the context of CefSharp.

//use the following instead
var devToolsContext = await chromiumWebBrowser.GetDevToolsContextAsync()

• Merge CefSharp.Puppeteer into CefSharp.Puppeteer.Embedded
• Remove CefSharp.Puppeteer
• Rename CefSharp.Puppeteer.Embedded to CefSharp.Puppeteer

Simplifies creation of Nuget package, reduces the project down to a single dll.

The project is being renamed, the repository has been updated. A new nuget package should hopefully be available next week with an improved DOM API.

Error code

There was a mismatch between the processor architecture of the project being built "x86" and the processor architecture of the reference "CefSharp.Puppeteer, Version=1.0.22.0, Culture=neutral, PublicKeyToken=40c4b6fc221f4138, processorArchitecture=AMD64", "AMD64". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project.

Originally posted by @radiaku in #4 (reply in thread)

After upgrading to version 97 (#7) some of the mouse/keyboard tests started failing.

• When run via the debugger and stepping through the code they pass correctly.
• Likely something changed in Chromium.
• Checking through the commands send to CEF vs those generated using puppeteer sharp and nothing stands out so far.
• When running similar code from a WPF application it passes correctly.

Will skip the tests in the short term as the code appears to be working correctly when run under normal conditions (outside the test cases).

There are two Dispose scenarios:

1. User initiated
   • Needs to send the relevant DevTools commands so a new DevToolsContext can be created later if required.
   • Unhook events
   • Dispose of DevTools observer
2. ChromiumWebBrowser Dispose
   • Unhook events

For scenario #2 as the browser is disposing it's difficult and likely not necessary to send the DevTools commands

Description

When working with frames on some websites, I get entire application crash (it closed completely without any error alerts).
My initial setup to access frames:

settings.CefCommandLineArgs.Add("disable-features=IsolateOrigins");
settings.CefCommandLineArgs.Add("disable-site-isolation-trials");

It doesn't matter for this issue (crash occurs even without these settings), but they are required to have access to frames.

Crash moment

Here is code which leads to crash:

foreach (Frame fr in devTools.Frames)
{
	if (fr == null || fr.Detached)
		continue;
	ElementHandle element = fr.QuerySelectorAsync("#id").Result;
	if (element != null) //crashes on this line
	{
		return element;
	}
}

Strange thing is that it works on most websites, but on some ones it leads to crash every time.

Logs

In Logs, there are no fatal entries, but only few warning and error ones:
[0927/180147.326:ERROR:ssl_client_socket_impl.cc(983)] handshake failed; returned -1, SSL error code 1, net_error -101 [0927/180147.399:ERROR:ssl_client_socket_impl.cc(983)] handshake failed; returned -1, SSL error code 1, net_error -101 [0927/180147.554:WARNING:spdy_session.cc(3502)] Received HEADERS for invalid stream 21 [0927/180147.555:WARNING:spdy_session.cc(3502)] Received HEADERS for invalid stream 1 [0927/180147.585:WARNING:spdy_session.cc(3502)] Received HEADERS for invalid stream 25 [0927/180147.797:WARNING:spdy_session.cc(3502)] Received HEADERS for invalid stream 29 [0927/180147.797:WARNING:spdy_session.cc(3502)] Received HEADERS for invalid stream 5 [0927/180147.797:WARNING:spdy_session.cc(3502)] Received HEADERS for invalid stream 31 [0927/180148.081:ERROR:ssl_client_socket_impl.cc(983)] handshake failed; returned -1, SSL error code 1, net_error -101 [0927/180148.157:ERROR:ssl_client_socket_impl.cc(983)] handshake failed; returned -1, SSL error code 1, net_error -101

Puppeteer has a method (not included in puppeteer-sharp yet) for waiting for navigation, this would be very helpful.

https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#pagewaitfornetworkidleoptions

A number of the XUnit tests have started failing after upgrade. Likely changes in Chromium.

Tests appear to be mouse/keyboard input related. Most of the problems seem to be timing related, as when stepping through at least some of the test cases with the debugger they work as expected.