cedadev / django-dmp Goto Github PK

poppy.townsend [1:20 PM]
Merged with other project/ handled else where

When the user deletes a reminder, it can't find 'reminder' as a dict key.
When the user modifies a reminder, it can't find the state in the form.

Potential JS tool which will add to calendar http://addtocalendar.com/

Give informative error message and load a page rather than returning a server error.

Example:

Reminders for this project have been modified.
Reminder: "reply to Andy with DMP". Description has changed from: "follow up previous email to Andy" to: "reply to Andy with DMP"

When the uploader changes or updates a field, it should create a note listing the changes.

If there is more than one folder with the same name as the parent folder eg. DMP or 2013 then the DMP will be uploaded to every location where this is true.

Think of a way to indicate that this is not spam and the the receiver can reply, it will just reply to the sender.

I've spotted that the reporting stats for projects and actions aren't quite being calculated properly.

Basically, the issue is that the search for "projects with no reminders" is ignoring those projects with no open tasks but with 1 or more closed tasks. E.g. see : https://dmp.ceda.ac.uk/admin/dmp/project/330/change/

this has 2 completed tasks.... and doesn't show up under the "Project with no reminder" listing on https://dmp.ceda.ac.uk/dmp/todo_list/

[2:15]
and so the stats on this page aren't quite right either : https://dmp.ceda.ac.uk/dmp/todo_list/summary/

Just a note for now. Perhaps a section to the weekly email to show new projects assigned to you.

https://www.tiny.cloud/blog/how-to-migrate-from-tinymce-4-to-tinymce-5/

Grant numbers which caused issue:
NE/P003028/1 and NE/P002552/1

If you make a reminder without setting the "reminder interval" to custom or a date, it brings up a django error which would just be displayed as a 500 rather than giving the user useful feedback.

The user does not know where the file will be placed on upload or where it has gone.
Might be good to show where the file is going, perhaps allow the user to change the destination path.

[Wed Apr 05 09:53:52 2017] [error] [client ] django.request exception ERROR [2017-04-05 09:53:52,011] Internal Server Error: /dmp/google_drive_upload/559/
[Wed Apr 05 09:53:52 2017] [error] [client ] Traceback (most recent call last):
[Wed Apr 05 09:53:52 2017] [error] [client ] File "/usr/local/pyenv/lib/python2.7/site-packages/django/core/handlers/exception.py", line 39, in inner
[Wed Apr 05 09:53:52 2017] [error] [client ] response = get_response(request)
[Wed Apr 05 09:53:52 2017] [error] [client ] File "/usr/local/pyenv/lib/python2.7/site-packages/django/core/handlers/base.py", line 187, in _get_response
[Wed Apr 05 09:53:52 2017] [error] [client ] response = self.process_exception_by_middleware(e, request)
[Wed Apr 05 09:53:52 2017] [error] [client ] File "/usr/local/pyenv/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response
[Wed Apr 05 09:53:52 2017] [error] [client ] response = wrapped_callback(request, callback_args, **callback_kwargs)
[Wed Apr 05 09:53:52 2017] [error] [client ] File "/usr/local/pyenv/lib/python2.7/site-packages/dmp/views.py", line 75, in google_drive_upload
[Wed Apr 05 09:53:52 2017] [error] [client ] result.write(html.encode("ISO-8859-1"))
[Wed Apr 05 09:53:52 2017] [error] [client ] File "/usr/local/pyenv/lib/python2.7/site-packages/django/utils/functional.py", line 15, in _curried
[Wed Apr 05 09:53:52 2017] [error] [client ] return _curried_func((args + moreargs), *dict(kwargs, morekwargs))
[Wed Apr 05 09:53:52 2017] [error] [client ] File "/usr/local/pyenv/lib/python2.7/site-packages/django/utils/safestring.py", line 104, in _proxy_method
[Wed Apr 05 09:53:52 2017] [error] [client ] data = method(self, args, kwargs)
[Wed Apr 05 09:53:52 2017] [error] [client ] UnicodeEncodeError: 'latin-1' codec can't encode character u'\u2013' in position 17123: ordinal not in range(256)
[Wed Apr 05 09:53:54 2017] [error] [client ] requests.packages.urllib3.connectionpool connectionpool DEBUG [2017-04-05 09:53:54,512] Starting new HTTPS connection (1): www.googleapis.com
[Wed Apr 05 09:53:54 2017] [error] [client ] requests.packages.urllib3.connectionpool connectionpool DEBUG [2017-04-05 09:53:54,582] https://www.googleapis.com:443 "POST /oauth2/v4/token HTTP/1.1" 200 None
[Wed Apr 05 09:53:54 2017] [error] [client ] requests.packages.urllib3.connectionpool connectionpool DEBUG [2017-04-05 09:53:54,588] Starting new HTTPS connection (1): www.googleapis.com
[Wed Apr 05 09:53:54 2017] [error] [client ] requests.packages.urllib3.connectionpool connectionpool DEBUG [2017-04-05 09:53:54,789] https://www.googleapis.com:443 "GET /oauth2/v3/userinfo?access_token= HTTP/1.1" 200 None

When the user makes a change to a reminder, be that modify description/due date, delete or complete, create a new note against the project. Also allow the user to make additional comments at the same time.

on branch dmp-site-python-3 - moved admin templates outside of app. Do they need to be here?

When adding a new reminder the element is created dynamically. I think the calendar is attached to -due_date ids which exist on page load which means that the calendar does not show for these dynamically created elements.

Have a way of flagging when projects require action and present a list of projects where this date has passed and which ones are upcoming. Gives a shortened list where projects which do not require attention for some time are not shown.

On branch dmp-site-python-3: order of buttons is incorrect. Home, Projects, Grants should come before welcome/login/logout

Log uploads in notes.

If you add a new email template object or change the name of an existing object, the dropdown on the template selector form does not change.

url https://dmp.ceda.ac.uk/admin/ has 'CEDA database administration' navigation bar - not sure where this is from and doesn't exist on branch dmp-site-python-3

Add a dropdown field with options:

• Initial contact
• DMP comms
• Progress
• Data delivery

On the todo list, display the status and give a count for each type at the end of the summary table.