cdsmith / cfrac Goto Github PK

Instead of allowing the user to build invalid continued fractions and exporting isCanonical to detect them, we ought to have a smart constructor that automatically corrects these infelicities on the fly.

Then a good question is whether to export the underlying constructor. Maybe :+/ itself should be turned into a pattern synonym that does this conversion but can still be matched on to access the underlying terms.

The existing implementation assumes that all numbers are non-negative.

There is an implementation of floating point operations in https://hackage.haskell.org/package/cf, but it doesn't seem to work in my tests. Where computationally feasible, it would be nice to implement these operations on CFrac, as well.