Coder Social home page Coder Social logo

Comments (6)

AntoineAugusti avatar AntoineAugusti commented on June 20, 2024

The main problem is with our deploy pipeline https://github.com/cds-snc/notification-pr-bot/blob/aa7a3a15129dd3dd48111c4f82ab7b50f643d9de/index.js#L17-L43 and Kubernetes https://github.com/cds-snc/notification-manifests

from notification-api.

AntoineAugusti avatar AntoineAugusti commented on June 20, 2024

Related to cds-snc/notification-admin#1020 cds-snc/notification-pr-bot#16 cds-snc/notification-document-download-frontend#55 cds-snc/notification-document-download-api#38

from notification-api.

dj2 avatar dj2 commented on June 20, 2024

For the PR bot, what happens if there is an entry in there for a branch that doesn't exist? Do we know if the bot will just ignore it? If it does, we could add 'main' alongside 'master' in the list and then remove 'master' post deploy.

If it doesn't support it .... do we control the code, could I make it supported?

For Kubernetes, I don't have knowledge of kubernetes so I don't know how hard it would be to migrate. Do you deploy on every push? Could we prepare the kubernetes change in a branch that gets committed soon after the changes to other repos?

from notification-api.

yaelberger-commits avatar yaelberger-commits commented on June 20, 2024

@jzbahrai can you please have a look at this one? Thanks

from notification-api.

HEYGUL avatar HEYGUL commented on June 20, 2024

I have the feeling this issue could be closed (main branch seems now alive instead of master).

from notification-api.

jimleroyer avatar jimleroyer commented on June 20, 2024

Yes, the mainline branch for all our active projects are now in main for quite some time.

from notification-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.