Comments (6)
The main problem is with our deploy pipeline https://github.com/cds-snc/notification-pr-bot/blob/aa7a3a15129dd3dd48111c4f82ab7b50f643d9de/index.js#L17-L43 and Kubernetes https://github.com/cds-snc/notification-manifests
from notification-api.
Related to cds-snc/notification-admin#1020 cds-snc/notification-pr-bot#16 cds-snc/notification-document-download-frontend#55 cds-snc/notification-document-download-api#38
from notification-api.
For the PR bot, what happens if there is an entry in there for a branch that doesn't exist? Do we know if the bot will just ignore it? If it does, we could add 'main' alongside 'master' in the list and then remove 'master' post deploy.
If it doesn't support it .... do we control the code, could I make it supported?
For Kubernetes, I don't have knowledge of kubernetes so I don't know how hard it would be to migrate. Do you deploy on every push? Could we prepare the kubernetes change in a branch that gets committed soon after the changes to other repos?
from notification-api.
@jzbahrai can you please have a look at this one? Thanks
from notification-api.
I have the feeling this issue could be closed (main
branch seems now alive instead of master
).
from notification-api.
Yes, the mainline branch for all our active projects are now in main
for quite some time.
from notification-api.
Related Issues (20)
- Clean up old providers from the codebase
- 500 when switching language after creating an SMTP relay
- Move the email address used for DMARC reports to a config variable HOT 1
- Create a security.txt file for vulnerability disclosure practices HOT 4
- Replace moment.js
- Static assets caching
- Not possible to accept an org invite: KeyError blocked
- Update AWS Lambda for DB snapshots to secondary account
- Remove new user tour totally from code
- Fix npm run webpack
- API endpoint for data download from dashboard HOT 3
- Different psycopg error message in (failed) test HOT 5
- Missing personalization throws breaking exception HOT 3
- Error in tests (IntegrityError): The email address ((sending_email_address)) is not able to receive messages HOT 2
- Support x-www-form-urlencoded data to API url
- Refactor alerts to distinguish between infrastructure failure, capacity, or service limits HOT 5
- Getting the status of Bulk Notifications HOT 2
- Dependency Dashboard
- Not all notifications showing up on the api HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notification-api.