catly1 / moefy Goto Github PK

Hey Carlos! I've been using Spotify a lot lately, and I think this is going to be a great project - there are going to be a lot of fun features to implement.

I have a few suggestions for your proposal:

Schema:

• Songs should have a 'name' and a 'song_url'
• Albums need a 'name' and a 'year'

State Shape:

• Don't forget to include 'ui', 'errors', and 'session' outside of the entities object. See the sample proposal (https://github.com/appacademy/bluebird/wiki/sample-state)
• albums and artists need an 'image_url'

Your state shape looks good and it seems like you put some thought into it. Great work.

Functionality

​

• The main button with logo should link to /
• Has working demo login
• Smooth, bug free navigation
  ​

Before Login

​

• The /login page should not display a link to Log In. Same for /signup
• Going to a random route /#/oweiniouewbrviuwebv should redirect or display a 404 page
• Errors should display for both /signup and /login.
• Errors should clear when moving between /signup and /login.
• Can sign up a user
• Can sign in as a user
• Can log out a user
• Can't sign up with the same username/email
• Pressing enter after filling out the session form should use the form data, not the demo user
  ​

After Login

​

• Should not be able to visit /login or /signup
• Should be able to refresh the page and still be logged in
  ​
  ​

Style

​

• The site should look exactly like the actual site
• All relevant elements should have cursor: pointer on hover
• When errors are displayed, most elements should not move around the page (particularly input boxes)
• Remove Redux logger and all console.log()'s from production
  ​

Seeds

• Adequate and appropriate seeds