catalyst / moodle-block_carousel Goto Github PK

View Code? Open in Web Editor NEW

3.0 25.0 2.0 754 KB

A simple, responsive and touch friendly moodle carousel block

License: GNU General Public License v3.0

PHP 27.92% JavaScript 62.38% Makefile 0.04% Ruby 0.05% CSS 1.98% Less 1.97% SCSS 2.17% HTML 3.16% Mustache 0.33%

moodle-plugin carousel moodle-block

moodle-block_carousel's Issues

Clean up code to get workflows reporting green

Resubmit to plugin directory

https://moodle.org/plugins/block_carousel

Dragging on a slide which also has a click popup triggers the popup and should not

Restored carousel contains references to backed up activity

The slide references in the restored activity contain references to the old block id, not the restored block id.

Load the css and js through the moodle file serving api to give it the correct caching headers + version

Add ability to limit visibility of slides to specific cohorts.

Add cohort filtering support to the plugin.

Slides can have a set of cohorts selected to display that slide only to members of those cohorts.
The slide table on the block configuration page will have an extra column to list the cohorts selected.
A slide will be visible if the user is a member of at least one cohort in the list for that slide.
Selecting no cohorts will default to original behaviour (visible to everyone).
Admins will always be able to see all slides.

Restore fails when there is a carousel block instance backed up against a course with no config data set

This happens when the user adds a block but never configures it.

Which causes a similar error to this to happen.

PHP Warning:  Attempt to read property "order" on bool in /var/www/site/blocks/carousel/backup/moodle2/restore_carousel_stepslib.php on line 90
PHP Deprecated:  explode(): Passing null to parameter #2 ($string) of type string is deprecated in /var/www/site/blocks/carousel/backup/moodle2/restore_carousel_stepslib.php on line 90
PHP Warning:  Undefined array key "" in /var/www/site/blocks/carousel/backup/moodle2/restore_carousel_stepslib.php on line 93

Number of clicks is reset to zero when editing a slide

Currently the number of interactions is reset to zero when editing a slide.

moodle-block_carousel/add_slide.php

Line 140 in 4bbed5d

$record->interactions = 0;

The default database value is also zero. If the line above was removed, the interactions would be saved when editing a slide.

moodle-block_carousel/db/install.xml

Line 15 in 4bbed5d

    
           <FIELD NAME="interactions" TYPE="int" LENGTH="10" NOTNULL="true" DEFAULT="0" SEQUENCE="false"/>

Adding a slide places the new content at the end of the carousel

When adding a new slide, it would be preferred that as it is new content, the slide is the first to display.

edit form only show first 3 slides - other slides will not be displayed if updating carousel with more than 3 slides

Current form does not check for existing number of slides:
https://github.com/catalyst/moodle-block_carousel/blob/master/edit_form.php#L73

If carousel has more than 3 slides, those added after slide 3 will not be displayed. (user need to click on "add another slide" button to show next slide).

Test is pathtoffprobe binary exists not just if the setting is set

https://github.com/catalyst/moodle-block_carousel/blob/master/classes/cache/slide_cache.php#L146

Error when installing a fresh 4.1 site with MySQL and block_carousel

Exception - mysqli::real_escape_string(): Argument #1 ($string) must be of type string, array given

More information about this error

It is usually not possible to recover from errors triggered during installation, you may need to create a new database or use a different database prefix if you want to retry the installation.
Debug info:
Error code: generalexceptionmessage
Stack trace:

line 1145 of /lib/dml/mysqli_native_moodle_database.php: TypeError thrown
line 1145 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli->real_escape_string()
line 1357 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->emulate_bound_params()
line 1408 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->insert_record_raw()
line 1318 of /lib/upgradelib.php: call to mysqli_native_moodle_database->insert_record()
line 648 of /lib/upgradelib.php: call to external_update_descriptions()
line 1108 of /lib/upgradelib.php: call to upgrade_component_updated()
line 684 of /lib/upgradelib.php: call to upgrade_plugins_blocks()
line 1967 of /lib/upgradelib.php: call to upgrade_plugins()
line 726 of /admin/index.php: call to upgrade_noncore()

SVGs not well supported even though listed in "accepted file types"

Uploading an SVG causes errors to appear as below. We've tried updating web_image to a fixed list of supported types, but this didn't work in Totara 16 and broke image uploads.

Example test using PNG

: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
147

Notice
: Undefined property: stdClass::$widthres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
147

Notice
: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
172

Notice
: Undefined property: stdClass::$widthres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Notice
: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Warning
: Division by zero in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Notice
: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
147

Notice
: Undefined property: stdClass::$widthres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
147

Notice
: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
172

Notice
: Undefined property: stdClass::$widthres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Notice
: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Warning
: Division by zero in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Notice
: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
147

Notice
: Undefined property: stdClass::$widthres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
147

Notice
: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
172

Notice
: Undefined property: stdClass::$widthres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Notice
: Undefined property: stdClass::$heightres in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Warning
: Division by zero in
/var/www/site/server/blocks/carousel/block_carousel.php
on line
175

Implement slide metadata

Implement some basic metadata and display this either in the slide table, or when editing a slide.

Slide author
Date created
Date modified

Missing file in sitedata spews debugging messages

File missing from disk should be handled a little more gracefully

Referencing unset values in add_slide.php

If you submit a carousel add slide form with the No Title checkbox ticked, this error occurs.

Notice: Undefined property: stdClass::$title in
/var/www/.../blocks/carousel/add_slide.php on line 136

The same happens with $text.

Add github CI actions

Even if the plugin doesn't have any tests, it's still nice to have CI configured.

paddingbottom undefined error when files not available

I'm having issues on a dev environment with the paddingbottom variable being undefined at this line:

https://github.com/catalyst/moodle-block_carousel/blob/master/block_carousel.php#L163

This may just be an issue when using a database snapshot when the underlying files haven't been copied over. However, it could probably be resolved by giving the variable a default value before the foreach ($files as $file) loop.

Implement ability to archive slides in a carousel

Create ability to retain all slide data another mform section. Feature to move slides to the archive and back.

Get block_carousel to work with Totara16

Version table for README

The docs could be updated to use a format similar to that for the rest of our plugins, by having a version table listing out supported versions and relevant branches that needs to be defined. Currently it's just plaintext which might be missed if skimming the docs (in search for the table)

catalyst / moodle-block_carousel Goto Github PK

moodle-block_carousel's Issues

Recommend Projects

Recommend Topics

Recommend Org