Android save.json character reset bug about cataclysm-bn

[olanti-p]

I'm not sure what's precisely going on here, but it seems that the game uses wrong parser function for reading the saved integer back from JSON. It saves a 64-bit integer, but tries to load it back as a 32-bit integer, so it doesn't fit and throws a parse error.

Uploading Cridersville.zip…

It seems you have submitted the issue form before waiting for the upload to finish (the text changes to file name once that happens).

[olanti-p]

On further thought, in code that number means count of references, which in theory should stay far, far, far below limits of 32-bit unsigned int.

Cataclysm-BN/src/safe_reference.cpp

Lines 23 to 26 in 5ab65d5

	uint32_t count = it.second->json_count;
	if( count != 0 ) {
	json.write( id );
	json.write( count );

But in the screenshot, it seems that the count has reached -1 for some reason, which caused overflow and had it appear as 2^32-1 = 4294967295, which got saved, and then promptly failed to be loaded.
So the root of the issue is more likely somewhere inside reference tracking code.

[olanti-p]

For archival purposes, here's the save file from the issue:
Cridersville.zip

And the problematic snippet:

  "safe_references": { "items": [ 11602, 4294967295 ] },

Another save file from same user:
Boulder.zip

Different values this time - this doesn't even look like integer overflow, maybe memory corruption?

  "safe_references": { "items": [ 18446744073709551615, 2636248448, 11322597028362325620, 2636247792, 98784247841, 50559 ] },

As a note, those numbers don't repeat anywhere else in the save folder.