caskater4 / pyrocopy Goto Github PK

pyrocopy doesn't handle IOErrors when copying. For example:

pyrocopy %USERPROFILE% %TEMP%\test\pyro -q

Traceback (most recent call last):
  File "C:\Users\USERNAME\AppData\Roaming\Python\Scripts\pyrocopy.exe", line 9, in <module>
    sys.exit(main())
  File "C:\Users\USERNAME\AppData\Roaming\Python\Python27\site-packages\pyrocopy\__init__.py", line 57, in main
    results = pyrocopy.copy(args.source, args.destination, includeFiles=args.includefiles, includeDirs=args.includedirs, excludeFiles=args.excludefiles, excludeDirs=args.excludedirs, level=args.level, followLinks=args.followlinks, forceOverwrite=args.force, preserveStats=(not args.nostat))
  File "C:\Users\USERNAME\AppData\Roaming\Python\Python27\site-packages\pyrocopy\pyrocopy.py", line 263, in copy
    preserveStats=preserveStats)
  File "C:\Users\USERNAME\AppData\Roaming\Python\Python27\site-packages\pyrocopy\pyrocopy.py", line 999, in _copyFile
    with open(src, 'rb') as fsrc:
IOError: [Errno 13] Permission denied: 'C:\\Users\\USERNAME\\NTUSER.DAT'

This allows the logger for this module to be managed by itself in the context of a larger application, and is recommended practice in the docs for logging.

I haven't been able to test this as I don't have a UNIX/*BSD system, but I think the try...except... part of _copyStats() that copies the flags uses the errno module, but it doesn't appear to be imported anywhere.

Especially for transferring to a network share, it may be advantageous to have a larger buffer size. I got a 33% speed increase transferring a 740 G file over gigabit to a samba share (Win XP VM to CentOS host) by bumping up the buffer size to as much a 4MiB. I propose making a module-level variable in pyrocopy.py that is used in _copyFile() to set the buffer size in kiB.

should be like this
results = copy(path1, path2, includeFiles=includeFiles, includeDirs=includeDirs, excludeFiles=excludeFiles,
excludeDirs=excludeDirs, level=level, followLinks=followLinks, forceOverwrite=forceOverwrite,
preserveStats=preserveStats, detailedResults=True)
results2 = copy(path2, path1, includeFiles=includeFiles, includeDirs=includeDirs, excludeFiles=excludeFiles,
excludeDirs=excludeDirs, level=level, followLinks=followLinks, forceOverwrite=forceOverwrite,
preserveStats=preserveStats, detailedResults=True)

This should be pretty easy--mostly just augmenting 2to3 output.