cartridge-gg / dope-world Goto Github PK

I get this error after pressing Approve using frame wallet. No issues with Rainbow wallet

When accidentally scrolling on the input field goes negative. Would also be helpful to have locale specific thousands separator (ie 1,000 or 1.000)

For the UI it's great to have the l2TxHash, however, this transaction hash is currently a totally arbitrary value and can lead to data inconsistency.

I would recommend to put the l2TxHash inside the message. This way, we ensure the transaction hash given always match the actual hash from Starknet thanks to the message hash computation done by Starknet messaging contract.

This would require to inject the transaction hash here:

This name could be misleading as it corresponds to a deposit on the L2. I would call it deposit to match it's functionality and reuse the same name as done on L1.