carolineschnapp / carolineschnapp-gift-wrap Goto Github PK

A customer noticed this and I was able to replicate it.

Steps to Replicate

1. Add Products to Cart
2. Check Gift Wrap Box
3. Remove Gift Wrap from Cart (Not by Unchecking Box but by Cart/Themes Natural Remove)

At this point, Line 79 Fires and Re-Adds to Gift Wrap to Cart since Box is Checked Still.

issue = https://watch.screencastify.com/v/zbKFUaiUTvRsIqNsomZ9

My code below: Please help! :)

{% if linklists.gift-wrapping.links.size > 0 and linklists.gift-wrapping.links.first.type == 'product_link' %}

{% assign id = linklists.gift-wrapping.links.first.object.variants.first.id%}

{% assign gift_wraps_in_cart = 0 %}
{% for item in cart.items %}
{% if item.id == id %}
{% assign gift_wraps_in_cart = item.quantity %}
{% endif %}
{% endfor %}
{% assign items_in_cart = cart.item_count | minus:gift_wraps_in_cart %}

<style> #updates_{{ id }} { display: none; } </style> <script> Shopify.Cart = Shopify.Cart || {}; Shopify.Cart.GiftWrap = {}; Shopify.Cart.GiftWrap.set = function() { var headers = new Headers({ 'Content-Type': 'application/json' }); var request = { method: 'POST', headers: headers, body: JSON.stringify({ updates: { {{ id }}: {{ items_in_cart }} }, attributes: { 'gift-wrapping': true } }) }; fetch('/cart/update.js', request) .then(function() { location.href = '/cart'; }); } Shopify.Cart.GiftWrap.remove = function() { var headers = new Headers({ 'Content-Type': 'application/json' }); var request = { method: 'POST', headers: headers, body: JSON.stringify({ updates: { {{ id }}: 0 }, attributes: { 'gift-wrapping': '', 'gift-note': '' } }) }; fetch('/cart/update.js', request) .then(function() { location.href = '/cart'; }); } // If we have nothing but gift-wrap items in the cart. {% if cart.items.size == 1 and gift_wraps_in_cart > 0 %} document.addEventListener("DOMContentLoaded", function(){ Shopify.Cart.GiftWrap.remove(); }); // If we don't have the right amount of gift-wrap items in the cart. {% elsif gift_wraps_in_cart > 0 and gift_wraps_in_cart != items_in_cart %} document.addEventListener("DOMContentLoaded", function(){ Shopify.Cart.GiftWrap.set(); }); // If we have a gift-wrap item in the cart but our gift-wrapping cart attribute has not been set. {% elsif gift_wraps_in_cart > 0 and cart.attributes.gift-wrapping == blank %} document.addEventListener("DOMContentLoaded", function(){ Shopify.Cart.GiftWrap.set(); }); // If we have no gift-wrap item in the cart but our gift-wrapping cart attribute has been set. {% elsif gift_wraps_in_cart == 0 and cart.attributes.gift-wrapping != blank %} document.addEventListener("DOMContentLoaded", function(){ Shopify.Cart.GiftWrap.set(); }); {% endif %} // When the gift-wrapping checkbox is checked or unchecked. document.addEventListener("DOMContentLoaded", function(){ document.querySelector('[name="attributes[gift-wrapping]"]').addEventListener("change", function(event) { if (event.target.checked) { Shopify.Cart.GiftWrap.set(); } else { Shopify.Cart.GiftWrap.remove(); } }); document.querySelector('#gift-note').addEventListener("change", function(evt) { var note = evt.target.value; var headers = new Headers({ 'Content-Type': 'application/json' }); var request = { method: 'POST', headers: headers, body: JSON.stringify({ attributes: { 'gift-note': note } }) }; fetch('/cart/update.js', request); }); }); </script>

{% else %}

You attempted to add a gift-wrapping script to your shopping cart, but it won't work because you don't have a link list with handle gift-wrapping which, in turn, contains a link to your gift-wrapping product. Please review the steps outlined here.

{% endif %}