carlosmarti / godotappodeal Goto Github PK

Add the two callback functions from the new commit to the readme

It's been a while since i saw why my code isnt working :D

it is Interstital instead of Interstitial like in showInterstitialAd() and showInterstitialAndVideoAds()

also in isInterstitalLoaded()

I cloned the repository and I moved the appodeal/ subfolder to modules/ and after compiling using scons p=android I get this error

scons: Reading SConscript files ...
Godot Android!!!!! (armv7) (with neon)
AttributeError: 'SConsEnvironment' object has no attribute 'android_module_file':
  File "/home/jed/godot/SConstruct", line 307:
    config.configure(env)
  File "./modules/appodeal/config.py", line 6:
    env.android_module_file("android/GodotAppodeal.java")

If anyone has any thoughts please let me know what I can do to get around this.

Hi there,

my Gradle-Build fails, because it can not find the required Play Service version:

`Parallel execution with configuration on demand is an incubating feature.
:preBuild UP-TO-DATE
:preDebugBuild UP-TO-DATE
:checkDebugManifest
:prepareDebugDependencies
:compileDebugAidl UP-TO-DATE
:compileDebugRenderscript UP-TO-DATE
:generateDebugBuildConfig UP-TO-DATE
:generateDebugAssets UP-TO-DATE
:mergeDebugAssets UP-TO-DATE
:generateDebugResValues UP-TO-DATE
:generateDebugResources UP-TO-DATE
:mergeDebugResources UP-TO-DATE
:processDebugManifest
:processDebugResources
Position 225:28-65 : No resource found that matches the given name (at 'value' with value '@integer/google_play_services_version').

:processDebugResources FAILED

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':processDebugResources'.

  com.android.ide.common.process.ProcessException: org.gradle.process.internal.ExecException: Process 'command '/home/Android/sdk/build-tools/19.1.0/aapt'' finished with non-zero exit value 1

• Try:
  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 2.638 secs
`

I tried hard (but failed) to find a jar that matches the following dependency (from build.gradle):
com.google.android.gms:play-services-ads:+

Is the current version of the Play Service not suppoted by the module?

When i call this function the first this work, but when i close the InterstitialAd by button close in the top right position and then when ads is close i try to open again by button, so when i click the button the ads not show. I don't this is problem or not. but how can I show this, if this ads just show once?

The reward video finished callback is not working

There is a plan on making a version compatible with Godot 3.0, or this one works fine?

hey, how can I debug onRewardedVideoFailedToLoad() functoin?

State:
After successful SCons compilation, when I try to build the APK using Gradle, I get below error(s) (Error Log).
I have little to no experiences with Java, so can't presume what's happening. Any help or suggestion will be greatly appreciated.

What I Did:

• Copied the appodeal folder and placed it inside <godot_root>/modules folder, and compiled using scons platform=android target=release_debug.
• SCons compilation went successful, then copied the resulting *.so file from <godot_root>/bin folder into <godot_root>/platform/android/java/libs/armeabi folder.
  (Generally Godot's first SCons compilation copies the *.so file into <godot_root>/platform/android/java/libs/debug/armeabi-v7a folder, and I have tried for both scenarios.)
• Then, from <godot_root>/platform/android/java folder, tried compiling using gradlew.bat build command, and the error occurred.

Git Branches and Commits:
GodotAppodeal: master a292e8b
GodotEngine: master 5545afd

Error Log:

E:\clones\godot\platform\android\java>gradlew.bat build
Incremental java compilation is an incubating feature.
:preBuild UP-TO-DATE
:preDebugBuild UP-TO-DATE
:checkDebugManifest
:preReleaseBuild UP-TO-DATE
:prepareComAndroidSupportSupportV42340Library UP-TO-DATE
:prepareComGoogleAndroidGmsPlayServicesAds840Library UP-TO-DATE
:prepareComGoogleAndroidGmsPlayServicesBasement840Library UP-TO-DATE
:prepareDebugDependencies
:compileDebugAidl UP-TO-DATE
:compileDebugRenderscript UP-TO-DATE
:generateDebugBuildConfig UP-TO-DATE
:mergeDebugShaders UP-TO-DATE
:compileDebugShaders UP-TO-DATE
:generateDebugAssets UP-TO-DATE
:mergeDebugAssets UP-TO-DATE
:generateDebugResValues UP-TO-DATE
:generateDebugResources UP-TO-DATE
:mergeDebugResources UP-TO-DATE
:processDebugManifest UP-TO-DATE
:processDebugResources UP-TO-DATE
:generateDebugSources UP-TO-DATE
:incrementalDebugJavaCompilationSafeguard UP-TO-DATE
:compileDebugJavaWithJavac
E:\clones\godot\modules\appodeal\android\src\GodotAppodeal.java:107: error: cannot find symbol
            Appodeal.show(activity, Appodeal.BANNER_CENTER);
                                            ^
  symbol:   variable BANNER_CENTER
  location: class Appodeal
E:\clones\godot\modules\appodeal\android\src\GodotAppodeal.java:211: error: <anonymous org.godotengine.godot.GodotAppodeal$2> is not abstract and does not override abstract method onBannerLoaded(int,boolean) in BannerCallbacks
        Appodeal.setBannerCallbacks(new BannerCallbacks() {
                                                          ^
E:\clones\godot\modules\appodeal\android\src\GodotAppodeal.java:212: error: method does not override or implement a method from a supertype
            @Override
            ^
E:\clones\godot\modules\appodeal\android\src\GodotAppodeal.java:238: error: <anonymous org.godotengine.godot.GodotAppodeal$3> is not abstract and does not override abstract method onSkippableVideoClosed(boolean) in SkippableVideoCallbacks
        Appodeal.setSkippableVideoCallbacks(new SkippableVideoCallbacks() {
                                                                          ^
E:\clones\godot\modules\appodeal\android\src\GodotAppodeal.java:263: error: method does not override or implement a method from a supertype
            @Override
            ^
E:\clones\godot\modules\appodeal\android\src\GodotAppodeal.java:270: error: <anonymous org.godotengine.godot.GodotAppodeal$4> is not abstract and does not override abstract method onRewardedVideoClosed(boolean) in RewardedVideoCallbacks
        Appodeal.setRewardedVideoCallbacks(new RewardedVideoCallbacks() {
                                                                        ^
E:\clones\godot\modules\appodeal\android\src\GodotAppodeal.java:295: error: method does not override or implement a method from a supertype
            @Override
            ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
7 errors
:compileDebugJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 14.164 secs

Can you please look into this. If any information is needed, I'll be happy to provide.

Thanks :)

@carlosmarti could you add usage example

Hello Carlos,

I love your work, it really makes adding ad support easy.

I'm getting warnings for my Android app saying the currently used MoPub version has some security issues.

Any idea how to fixed that?

My best guess is to replace one of the included Jar-Files with a newer version, however I don't know which.