capawesome-team / capacitor-android-dark-mode-support Goto Github PK

Is your feature request related to a problem? Please describe:
As stated in readme, Capacitor v4 supports dark mode on Android - however it doesn't work for WebView versions lower than ~ v100.
At the same time, Capacitor v4 supports Android WebView 60+

Describe the solution you'd like:

• Un-depreacate plugin
• Add Capacitor v4 compatibility (constant has changed in androidx.webkit 1.3)

  src/main/java/dev/robingenz/capacitor/androiddarkmodesupport.java
   if (WebViewFeature.isFeatureSupported(WebViewFeature.FORCE_DARK_STRATEGY)) {
  -    WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.WEB_THEME_DARKENING_ONLY);
  +    WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.DARK_STRATEGY_WEB_THEME_DARKENING_ONLY);
   }

• Add note that plugin is required for older WebView versions

Describe alternatives you've considered:
I've tried @aparajita/capacitor-dark-mode however it's not a straight forward drop-in solution as this plugin is

Additional context:
Some of related issues:

• ionic-team/capacitor-plugins#1010
• ionic-team/capacitor#4677

Plugin version:

1.0.1

Platform(s):
Android

Current behavior:
Gradle build fails because a constant is not recognized

Expected behavior:
It should build

Steps to reproduce:
Try to build the app

Related code:

        if (WebViewFeature.isFeatureSupported(WebViewFeature.FORCE_DARK_STRATEGY)) {
            WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.WEB_THEME_DARKENING_ONLY);
        }

Other information:
Error log:

            WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.WEB_THEME_DARKENING_ONLY);
                                                                              ^
  symbol:   variable WEB_THEME_DARKENING_ONLY
  location: class WebSettingsCompat

I think it might be replaced with

        if (WebViewFeature.isFeatureSupported(WebViewFeature.FORCE_DARK_STRATEGY)) {
            WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.DARK_STRATEGY_WEB_THEME_DARKENING_ONLY);
        }

Capacitor doctor:

💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 4.3.0
  @capacitor/core: 4.3.0
  @capacitor/android: 4.3.0
  @capacitor/ios: 4.3.0

Installed Dependencies:

  @capacitor/cli: 4.0.1
  @capacitor/android: 4.0.0
  @capacitor/core: 4.0.0
  @capacitor/ios: 4.0.1

[success] iOS looking great! 👌
[success] Android looking great! 👌