cap-js / graphql Goto Github PK

Just had all tests of a branch version fail because I forgot to delete my local package-lock.json before npm installing the branch version.

This pit could be avoided by either adding a package-lock.json, or by adding a .npmrc with package-lock=false.

Depending on the load on my machine some or all tests fail due to timeout. The number of failing tests varies, and all tests succeeding is the exception:

A worker process has failed to exit gracefully and has been force exited. This is likely caused by
tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active
timers can also cause this, ensure that .unref() was called on them.
                                                                                                                    
Test Suites: 14 failed, 3 passed, 17 total                                                                          
Tests:       103 failed, 53 skipped, 126 passed, 282 total                                                          
Snapshots:   0 total                                                                                                
Time:        15.518 s 

Increasing the default timeout circumvents the problem, see #16

Queries that request fields with null values fail with error message

Cannot read properties of undefined (reading 'selections')

This could be reproduced by adding a contemporary author whose dateOfDeath and placeOfDeath are null and issuing a query that includes this author and one of these fields.

some description

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-3
Explanation: Is it registered in REUSE? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Hi! After upgrading to 0.3.0 I have now this error message:
Error: ENOENT: no such file or directory, stat '/workspace/node_modules/@cap-js/graphql/app/graphiql.html'

It looks like app folder hasn't been published:
https://www.npmjs.com/package/@cap-js/graphql?activeTab=explore

... to experiment with automated issue detection.

Hi!

As it's declared here https://github.com/graphql/express-graphql#this-library-is-deprecated express-graphql is not recommended for use anymore. It's using outdated approach.

I'd recommend to switch to https://github.com/graphql/graphql-http

Here is the example how it should be used with express.
https://github.com/graphql/graphql-http#with-express

Also may be it makes sense to think of even starting a separate graphql server, for example by use of Yoga:
https://github.com/graphql/graphql-http#servers

What do you think?

Thanks!

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-4
Explanation: Is it compliant with REUSE rules? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

I'd like to report also one more issue ew face currently

We've created a custom authorization layer by use of the following config
"auth": { "impl": "srv/auth.js" } where we implement is function to check user roles https://cap.cloud.sap/docs/node.js/authentication#user-is
However in case of graphql requests this code is simply not called.
I think i'd be nice to support auth here too.

Thanks!

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-2
Explanation: Does it have LICENSES directory with licenses? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-1
Explanation: Does README mention REUSE? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-2
Explanation: Does it have LICENSES directory with licenses? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-4
Explanation: Is it compliant with REUSE rules? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html