canlab-cz / triple Goto Github PK

tripled_64 is crashing when setting user defined bittiming.

sudo ./tripled_64 ttyACM0 -s0x09:0x0A:0x21 -c10:6:1:1:10:6:1:1:0:0:2 -ncan0:can1:canfd2
Neoprávněný přístup do paměti (SIGSEGV)

With debugging prints:

sudo ./tripled_64 ttyACM0 -s0x09:0x0A:0x21 -c10:6:1:1:10:6:1:1:0:0:0 -ncan0:can1:canfd2
str=10, num=10
str=6, num=6
str=1, num=1
str=1, num=1
Neoprávněný přístup do paměti (SIGSEGV)

First problem is, that user_speed should have 11 items, not only 10:

Second problem is with tmp, which should also have 11 items:

Both are used in this loop:

I'm using Fedora 35 with kernel 5.16.11, but unfortunately, driver does not compile with this kernel version. I tried to fix it (see commit 97d4bc0), and I fixed compilation problems, but when executing candump, the whole system froze, so there is some other problem as well.

I'm missing predefined speeds with equal nominal and data baud rates. Would it be possible to add them?

Currently I'm setting 500/500 kb/s with -c10:6:1:1:10:6:1:1:0:0:0, is it correct?